Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cache Document#to_liquid #3693
I'm probably overlooking something, but this passes tests and (on my machine) shaves off about ~1.5 seconds of build time for the page in "site". Turns out
I don't know how "representative" the site in "site" is and if this PR has any value to "real" and bigger Jekyll pages.
CPU profile before (master)
As you can see,
CPU profile after (this branch)
And it's gone.
Naively comparing runtime
Memory profile before (master)
Memory profile after (this branch)
I'm not sure if the changes are safe, but tests pass for me locally. The only potential problem I can see is if someone changes the value of
@parkr, does this make any sense?
If not, then at least we now know that there is some untested behaviour :-)