Make Jekyll::Cleaner#existing_files more lazy #3696

Merged
merged 1 commit into from May 12, 2015

Conversation

Projects
None yet
4 participants
@fw42
Contributor

fw42 commented May 11, 2015

Small micro-optimization. Will probably not make a big difference for most sites, but on our ~6000 files site, it shaves off about a second off build time.

The optimization is to not call the keep_file_regex and keep_dirs methods in every single iteration of the block but only once at the beginning. Also use Regexp.union instead of that ugly hack.

@parkr

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 11, 2015

Contributor

My only complaint is the commit message, it's misleading because nothing here is actually lazier.

Contributor

envygeeks commented May 11, 2015

My only complaint is the commit message, it's misleading because nothing here is actually lazier.

@fw42

This comment has been minimized.

Show comment
Hide comment
@fw42

fw42 May 11, 2015

Contributor

updated the commit message

Contributor

fw42 commented May 11, 2015

updated the commit message

parkr added a commit that referenced this pull request May 12, 2015

@parkr parkr merged commit b90f6f7 into jekyll:master May 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request May 12, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.