Incremental: handle deleted/renamed/moved dependencies #3717

Merged
merged 1 commit into from May 31, 2015

Conversation

Projects
None yet
4 participants
@alfredxing
Member

alfredxing commented May 20, 2015

Should fix #3716. Added a test as well.

First PR in a long long time! 馃帀

@alfredxing alfredxing changed the title from Regenerator: handle deleted/renamed/moved dependencies to Incremental: handle deleted/renamed/moved dependencies May 20, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 20, 2015

Contributor

Fix the problem I had 馃憤

Contributor

envygeeks commented May 20, 2015

Fix the problem I had 馃憤

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing May 20, 2015

Member

Good to hear!
Why does JRuby have to be so slow... 馃悓

Member

alfredxing commented May 20, 2015

Good to hear!
Why does JRuby have to be so slow... 馃悓

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 20, 2015

Contributor

It's because we can only test right now on JRuby head because there were some problem with Gem and jruby17 so we have to not only download it (fresh) but we have to set it up 馃槩 hopefully it'll only be at max a few months. I might hit up @headius and see if he can figure out why the bundle+gem install problem regressed in the latest version.

Contributor

envygeeks commented May 20, 2015

It's because we can only test right now on JRuby head because there were some problem with Gem and jruby17 so we have to not only download it (fresh) but we have to set it up 馃槩 hopefully it'll only be at max a few months. I might hit up @headius and see if he can figure out why the bundle+gem install problem regressed in the latest version.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing May 20, 2015

Member

But even running the test suite is going at a crawl. Looking at the build, the script/cibuild command took 289.12s (just under 5 minutes)...

Member

alfredxing commented May 20, 2015

But even running the test suite is going at a crawl. Looking at the build, the script/cibuild command took 289.12s (just under 5 minutes)...

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing May 20, 2015

Member

Anyway, I'm pretty excited; I just noticed that this will be my 100th commit to the project! 馃帄
I'll wait for @parkr to take a look, unless you want to merge it in now.

Member

alfredxing commented May 20, 2015

Anyway, I'm pretty excited; I just noticed that this will be my 100th commit to the project! 馃帄
I'll wait for @parkr to take a look, unless you want to merge it in now.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 20, 2015

Contributor

That I can't explain tbh, I could be doing something wrong, I'll have a look at performance options for JRuby in a few minutes and see what I can push up to speed up our tests. There are tons of options. I'm fine waiting for @parkr since I already merged it locally!

Contributor

envygeeks commented May 20, 2015

That I can't explain tbh, I could be doing something wrong, I'll have a look at performance options for JRuby in a few minutes and see what I can push up to speed up our tests. There are tons of options. I'm fine waiting for @parkr since I already merged it locally!

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks May 20, 2015

Contributor

Oh and congrats 馃帀 on your 100th commit!

Contributor

envygeeks commented May 20, 2015

Oh and congrats 馃帀 on your 100th commit!

@parkr

This comment has been minimized.

Show comment
Hide comment
Member

parkr commented May 28, 2015

:shipit:

alfredxing added a commit that referenced this pull request May 31, 2015

@alfredxing alfredxing merged commit bba7870 into jekyll:master May 31, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.