New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: lib/jekyll/convertor/markdown.rb - tests: no additions/breaks. #3771

Merged
merged 2 commits into from Dec 27, 2015

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Jun 10, 2015

Reason: #3770
/cc @jekyll/core

redcarpet
] + third_party_processors
%W(rdiscount kramdown redcarpet) + \
third_party_processors

This comment has been minimized.

@parkr

parkr Jul 1, 2015

Member

I think this can be on one line. Also, how do %w and %W differ?

@parkr

parkr Jul 1, 2015

Member

I think this can be on one line. Also, how do %w and %W differ?

This comment has been minimized.

@envygeeks

envygeeks Jul 1, 2015

Contributor

They don't differ, it just happened automatically on my end and it's something I should probably remove in favor of the widely used %w[] for consistency.

@envygeeks

envygeeks Jul 1, 2015

Contributor

They don't differ, it just happened automatically on my end and it's something I should probably remove in favor of the widely used %w[] for consistency.

@@ -56,21 +65,35 @@ def output_ext(ext)
end
def convert(content)
setup
@parser.convert(content)
setup

This comment has been minimized.

@parkr

parkr Jul 1, 2015

Member

Let's leave this indented 2 spaces to ensure it's known that it's supposed to be a part of convert().

@parkr

parkr Jul 1, 2015

Member

Let's leave this indented 2 spaces to ensure it's known that it's supposed to be a part of convert().

setup
@parser.convert(
content
)

This comment has been minimized.

@parkr

parkr Jul 1, 2015

Member

I think this can be on one line.

@parkr

parkr Jul 1, 2015

Member

I think this can be on one line.

end
private
def get_custom_processor
md = @config["markdown"]

This comment has been minimized.

@parkr

parkr Jul 1, 2015

Member

converter_name, maybe? md confused me -- I thought it was supposed to be the markdown extension, e.g. ".md" or ".markdown".

@parkr

parkr Jul 1, 2015

Member

converter_name, maybe? md confused me -- I thought it was supposed to be the markdown extension, e.g. ".md" or ".markdown".

private
def custom_class_allowed?(parser_name)
parser_name !~ /[^A-Za-z0-9_]/ && self.class.constants.include?(

This comment has been minimized.

@parkr

parkr Jul 1, 2015

Member

Let's split this line on the && instead of on the include? args.

@parkr

parkr Jul 1, 2015

Member

Let's split this line on the && instead of on the include? args.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 1, 2015

Member

Great! Again, just style things, the substance looks great. Thanks, Jordon!

Member

parkr commented Jul 1, 2015

Great! Again, just style things, the substance looks great. Thanks, Jordon!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 8, 2015

Member

Still want to see this merged, @envygeeks ?

Member

parkr commented Dec 8, 2015

Still want to see this merged, @envygeeks ?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 8, 2015

Contributor

Yes, I forgot all about this, I'll re-review and it updated for the 3.1 release.

Contributor

envygeeks commented Dec 8, 2015

Yes, I forgot all about this, I'll re-review and it updated for the 3.1 release.

@envygeeks envygeeks added this to the 3.1 milestone Dec 8, 2015

@parkr parkr merged commit a58f23a into master Dec 27, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 27, 2015

@parkr parkr deleted the fixup-custom-markdown branch Dec 27, 2015

parkr added a commit that referenced this pull request Dec 27, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.