New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt StaticFile for collections, config defaults #3823
Conversation
I like it 👍 |
0743afd
to
3f90a2a
Compare
@envygeeks Thanks for the rapid feedback. All comments incorporated! |
Do you mind rebasing the two commits into a single commit and forcing it up again so that other reviewers can see both the changes and everything in on swift review? Thanks! |
3f90a2a
to
c66a874
Compare
No problem! Done. |
Nice work @mbland. Would be great to see this land in Jekyll core. |
title: '', | ||
}, | ||
}).to_s | ||
@url = @url.gsub /\/$/, '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is effectively @url.gsub!
– why not use the bang method here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I must've been thinking about how gsub!
will return nil if nothing was changed, and how that would not work as a return value. But it's not a return value here.
Looking pretty good! Thanks, @mbland. Looks like you're coming from a Python background, based on all those |
fa282bb
to
80ae0da
Compare
Can you please rebase all this into a single commit so that it can be re-reviewed in one swift shot. Thanks. |
This enables files such as images and PDFs to show up in the same relative output directory as other HTML and Markdown documents in the same collection. It also enables static files to be hidden using defaults from _config.yml in the same way that other documents in the same collection and directories may be hidden using `published: false`.
80ae0da
to
250b6eb
Compare
Yep! Done. |
Cool! |
Hey gang, not to nag, but is there further review pending, or is this ready to merge? |
This is ready! Sorry I didn't notice @parkr said to |
Adapt StaticFile for collections, config defaults
Sweeet, thanks, @envygeeks! |
This enables files such as images and PDFs to show up in the same relative output directory as other HTML and Markdown documents in the same collection.
It also enables static files to be hidden using defaults from _config.yml in the same way that other documents in the same collection and directories may be hidden using
published: false
.Extracted from 18F/hub#332.
cc: @afeld @gboone @jeremiak @dhcole