Fixes #3836. Fix site template header menu iteration variables #3838

Merged
merged 1 commit into from Jul 28, 2015

Conversation

Projects
None yet
5 participants
@gynter
Contributor

gynter commented Jul 6, 2015

Fixes issue #3836.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 6, 2015

Member

@envygeeks Can you please look into this JRuby error?

Member

parkr commented Jul 6, 2015

@envygeeks Can you please look into this JRuby error?

@jensechu

This comment has been minimized.

Show comment
Hide comment
@jensechu

jensechu Jul 6, 2015

Contributor

@parkr The same tests failed on my PR for a CSS comment change that was merged in. I think something is up with master?

Contributor

jensechu commented Jul 6, 2015

@parkr The same tests failed on my PR for a CSS comment change that was merged in. I think something is up with master?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 6, 2015

Contributor

@jensechu @parkr it's neither our or your fault, it looks like there is a problem with current jRuby head. I'll move jRuby to an allow to fail matrix but you're fine on your end.

Contributor

envygeeks commented Jul 6, 2015

@jensechu @parkr it's neither our or your fault, it looks like there is a problem with current jRuby head. I'll move jRuby to an allow to fail matrix but you're fine on your end.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 6, 2015

Contributor

/cc @jruby

Contributor

envygeeks commented Jul 6, 2015

/cc @jruby

@gynter

This comment has been minimized.

Show comment
Hide comment
@gynter

gynter Jul 28, 2015

Contributor

Has issues related to the builds resolved? If Yes then maybe merge this PR?

Contributor

gynter commented Jul 28, 2015

Has issues related to the builds resolved? If Yes then maybe merge this PR?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 28, 2015

Contributor

I will check to see in a little bit, I know that they were fixed on head because @headius got Travis-CI to update their images for jruby-head but right now we are waiting for stable to come out. If you guys feel this is safe to merge and I'll deal with the JRuby errors that pop up later since it's still experimental.

Contributor

envygeeks commented Jul 28, 2015

I will check to see in a little bit, I know that they were fixed on head because @headius got Travis-CI to update their images for jruby-head but right now we are waiting for stable to come out. If you guys feel this is safe to merge and I'll deal with the JRuby errors that pop up later since it's still experimental.

parkr added a commit that referenced this pull request Jul 28, 2015

@parkr parkr merged commit 14e6809 into jekyll:master Jul 28, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

parkr added a commit that referenced this pull request Jul 28, 2015

@gynter gynter deleted the gynter:issue-3836 branch Jul 28, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.