Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Cleaner: `keep_files` should only apply to the beginning of paths, not substrings with index > 0 #3849
For example, if someone is working under a folder something like
This would be confusing when a file is renamed while it is viewed on a browser. An user can be unaware of the fact that he is looking at outdated file (see #3847).
According to the documentation, the paths in
For these reasons, I made a change so that keep_files are interpreted as paths under the destination folder.
referenced this pull request
Jul 14, 2015
The example here doesn't apply to the feature.
Am I misreading you here?
First, thank you for your feedback.
I am afraid you are. I think of
Let me know if you are still unsure about my post. I know I am not a good writer.
@shinkondo I see, thank you for your patience.
This seems to have explained it for me. You have
I think what you described captures my issue, but please don't pull this request as of now.
It seems to me that the situation has changed because of bd2c337. My code in pull-request would not work. Now regex generated from
No, bd2c337 does not fix my issue.
As Travis CI showed, I was wrong to say that my code would not work. It seems that the code is using absolute paths again because of bd2c337.
In any case, I can fix my mistake in the test. Is there anything else I should do? I can try to squash/rebase the git log if that is preferable.