New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the scripts shebang for portability #3858

Merged
merged 1 commit into from Jul 20, 2015

Conversation

Projects
None yet
4 participants
@AJ-Acevedo
Contributor

AJ-Acevedo commented Jul 19, 2015

Updated all of the sh and bash shebangs for consistency and portability.
Resolves #3857

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 19, 2015

Contributor

Please re-add the set -e that was originally on the bash command (in script/test). Thanks!

Contributor

envygeeks commented Jul 19, 2015

Please re-add the set -e that was originally on the bash command (in script/test). Thanks!

@AJ-Acevedo

This comment has been minimized.

Show comment
Hide comment
@AJ-Acevedo

AJ-Acevedo Jul 19, 2015

Contributor

Will do. Should I squash it in or is a second commit fine?

Contributor

AJ-Acevedo commented Jul 19, 2015

Will do. Should I squash it in or is a second commit fine?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jul 19, 2015

Contributor

Squashing would be great!

Contributor

envygeeks commented Jul 19, 2015

Squashing would be great!

@AJ-Acevedo

This comment has been minimized.

Show comment
Hide comment
@AJ-Acevedo

AJ-Acevedo Jul 19, 2015

Contributor

As per this issue #!/usr/bin/env bash -e can cause problems on some systems.

This will work with the portable shebang

#!/usr/bin/env bash
set -e
Contributor

AJ-Acevedo commented Jul 19, 2015

As per this issue #!/usr/bin/env bash -e can cause problems on some systems.

This will work with the portable shebang

#!/usr/bin/env bash
set -e
Updated the scripts shebang for portability
- Updated all of the sh and bash shebangs for consistency and portability.
- set -e to the test script for portability
Resolves #3857

parkr added a commit that referenced this pull request Jul 20, 2015

@parkr parkr merged commit 0eee699 into jekyll:master Jul 20, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 20, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.