Add site.html_files to variables docs #3880

Merged
merged 1 commit into from Aug 4, 2015

Conversation

Projects
None yet
4 participants
@probins
Contributor

probins commented Aug 1, 2015

No description provided.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 1, 2015

Contributor

Please fix your html formatting! Thanks.

Contributor

envygeeks commented Aug 1, 2015

Please fix your html formatting! Thanks.

@probins

This comment has been minimized.

Show comment
Hide comment
@probins

probins Aug 1, 2015

Contributor

how do you mean? I didn't format anything. Just did a copy/paste in the online editor.

Contributor

probins commented Aug 1, 2015

how do you mean? I didn't format anything. Just did a copy/paste in the online editor.

@parkr

View changes

site/_docs/variables.md
+ <td><p><code>site.html_files</code></p></td>
+ <td><p>
+
+ A list of all static HTML files.

This comment has been minimized.

@parkr

parkr Aug 3, 2015

Member

This might be a little vague. What do you think about A list of all static files which end in .html?

@parkr

parkr Aug 3, 2015

Member

This might be a little vague. What do you think about A list of all static files which end in .html?

This comment has been minimized.

@probins

probins Aug 3, 2015

Contributor

I just copied what was in html_pages. It might be better if they both said something like that - make it clear that html_pages is a subset of pages and html_files is a subset of static_files. This wasn't clear to me from the current docs, though it's clear once you loop through them to see what they contain.

@probins

probins Aug 3, 2015

Contributor

I just copied what was in html_pages. It might be better if they both said something like that - make it clear that html_pages is a subset of pages and html_files is a subset of static_files. This wasn't clear to me from the current docs, though it's clear once you loop through them to see what they contain.

This comment has been minimized.

@parkr

parkr Aug 3, 2015

Member

Sure, you could include that piece. Feel free to clean up both.

@parkr

parkr Aug 3, 2015

Member

Sure, you could include that piece. Feel free to clean up both.

@probins

This comment has been minimized.

Show comment
Hide comment
@probins

probins Aug 4, 2015

Contributor

amended as discussed, and changed commit msg

Contributor

probins commented Aug 4, 2015

amended as discussed, and changed commit msg

parkr added a commit that referenced this pull request Aug 4, 2015

@parkr parkr merged commit 1b88345 into jekyll:master Aug 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 4, 2015

@probins probins deleted the probins:patch-1 branch Aug 5, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.