New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typofix - https://github.com/vlajos/misspell_fixer #3897

Merged
merged 2 commits into from Aug 8, 2015

Conversation

Projects
None yet
4 participants
@vlajos
Contributor

vlajos commented Aug 7, 2015

No description provided.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 7, 2015

Contributor

Please remove the font-awesome and split out the two typo's into two different commits. Thanks.

Contributor

envygeeks commented Aug 7, 2015

Please remove the font-awesome and split out the two typo's into two different commits. Thanks.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 7, 2015

Contributor

By remove font-awesome I mean remove your font-awesome, not remove font-awesome period.

Contributor

envygeeks commented Aug 7, 2015

By remove font-awesome I mean remove your font-awesome, not remove font-awesome period.

@vlajos

This comment has been minimized.

Show comment
Hide comment
@vlajos

vlajos Aug 7, 2015

Contributor

Done. Is it OK this way?

Contributor

vlajos commented Aug 7, 2015

Done. Is it OK this way?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Aug 7, 2015

Contributor

I'm fine with it as it stands but I'll digress my opinion on the commit msgs to @jekyll/core and @parkr

Contributor

envygeeks commented Aug 7, 2015

I'm fine with it as it stands but I'll digress my opinion on the commit msgs to @jekyll/core and @parkr

@vlajos

This comment has been minimized.

Show comment
Hide comment
@vlajos

vlajos Aug 7, 2015

Contributor

I don't adhere to the URLs in the commit messages.
I can remove them if you think it is better that way.

Contributor

vlajos commented Aug 7, 2015

I don't adhere to the URLs in the commit messages.
I can remove them if you think it is better that way.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 8, 2015

Member

@vlajos, yes, please remove the URLs in the commit messages and be a little more specific. Something like: Fixed typo in regenerator test comment. Then, :shipit:. Thanks!

Member

parkr commented Aug 8, 2015

@vlajos, yes, please remove the URLs in the commit messages and be a little more specific. Something like: Fixed typo in regenerator test comment. Then, :shipit:. Thanks!

@vlajos

This comment has been minimized.

Show comment
Hide comment
@vlajos

vlajos Aug 8, 2015

Contributor

Done.

Contributor

vlajos commented Aug 8, 2015

Done.

envygeeks added a commit that referenced this pull request Aug 8, 2015

@envygeeks envygeeks merged commit 571f75e into jekyll:master Aug 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.