filters: `where` should compare stringified versions of input & comparator #3935

Merged
merged 1 commit into from Aug 26, 2015

Conversation

Projects
None yet
2 participants
@parkr
Member

parkr commented Aug 26, 2015

Non-string input was being missed as a result of poor comparison.
Converting inputs to strings ensure numerical and boolean values are
properly compared.

Fixes #3911.

filters: `where` should compare stringified versions of input & compa…
…rator

Non-string input was being missed as a result of poor comparison.
Converting inputs to strings ensure numerical and boolean values are
properly compared.

Fixes #3911.

@parkr parkr added the fix label Aug 26, 2015

parkr added a commit that referenced this pull request Aug 26, 2015

@parkr parkr merged commit 831eb17 into master Aug 26, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the filter-where-to_s branch Aug 26, 2015

parkr added a commit that referenced this pull request Aug 26, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.