New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for Jekyll environment variables #3989

Merged
merged 2 commits into from Sep 23, 2015

Conversation

Projects
None yet
5 participants
@tomjoht
Contributor

tomjoht commented Sep 22, 2015

Information about Jekyll environment variables was missing from the documentation. This seemed like a good place to include it.

Added documentation for Jekyll environment variables
Information about Jekyll environment variables was missing from the documentation. This seemed like a good place to include it.
@parkr

View changes

Show outdated Hide outdated site/_docs/configuration.md
</td>
<td class="align-center">
<p><code class="flag">JEKYLL_ENV=production</code></p>
</td>

This comment has been minimized.

@parkr

parkr Sep 22, 2015

Member

Whoops! Looks like there is no closing </tr> here. Mind adding it and matching the indentation of the other lines?

@parkr

parkr Sep 22, 2015

Member

Whoops! Looks like there is no closing </tr> here. Mind adding it and matching the indentation of the other lines?

@parkr

View changes

Show outdated Hide outdated site/_docs/configuration.md
{% raw %}
{% if jekyll.environment == "production" %}
{% include disqus.html %}
{% endif %}

This comment has been minimized.

@parkr

parkr Sep 22, 2015

Member

Would you mind indenting so that {% include... is 2 spaces in?

@parkr

parkr Sep 22, 2015

Member

Would you mind indenting so that {% include... is 2 spaces in?

@parkr parkr added the Documentation label Sep 22, 2015

@parkr

View changes

Show outdated Hide outdated site/_docs/configuration.md
The default value for `JEKYLL_ENV` is `development`. Therefore if you omit `JEKYLL_ENV` from the build arguments, the default value will be `JEKYLL_ENV=development`. Any content inside `{% raw %}{% if jekyll.environment == "development" %}{% raw %}` tags will automatically appear in the build.
Your environment values can be anything you want (not just `development` or `production`). Some elements you might want to hide in development environments include Disqus comment forms or Google Analytics. Conversely, you might want to expose an "Edit me in Github" button in a development environment but not include it in production environments.

This comment has been minimized.

@parkr

parkr Sep 22, 2015

Member

Would you please capitalize the H in "GitHub"?

@parkr

parkr Sep 22, 2015

Member

Would you please capitalize the H in "GitHub"?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 22, 2015

Member

Thank you so much, Tom! This is excellent work. I really appreciate your input and work here ❤️

Member

parkr commented Sep 22, 2015

Thank you so much, Tom! This is excellent work. I really appreciate your input and work here ❤️

@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Sep 22, 2015

Contributor

I made the updates you noted, so it should be good now. Thanks.

Contributor

tomjoht commented Sep 22, 2015

I made the updates you noted, so it should be good now. Thanks.

parkr added a commit that referenced this pull request Sep 23, 2015

@parkr parkr merged commit 1bb8f9c into jekyll:master Sep 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 23, 2015

@tomjoht

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Sep 24, 2015

Contributor

I'm not sure why, but this code didn't get rendered properly in the build:

  {% raw %}
  {% if jekyll.environment == "production" %}
     {% include disqus.html %} 
     {% include disqus.html %} 
  {% endif %}
  {% endraw %}

Also, I accidentally used sentence case style in the "Specifying a Jekyll environment at build time" instead of title case (like the other sections).

Contributor

tomjoht commented on 38a561a Sep 24, 2015

I'm not sure why, but this code didn't get rendered properly in the build:

  {% raw %}
  {% if jekyll.environment == "production" %}
     {% include disqus.html %} 
     {% include disqus.html %} 
  {% endif %}
  {% endraw %}

Also, I accidentally used sentence case style in the "Specifying a Jekyll environment at build time" instead of title case (like the other sections).

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

If you want to email a git-patch to the email on my github I'll be happy to apply it directly without a pull.

Contributor

envygeeks replied Sep 24, 2015

If you want to email a git-patch to the email on my github I'll be happy to apply it directly without a pull.

This comment has been minimized.

Show comment
Hide comment
@jaybe-jekyll

jaybe-jekyll Sep 24, 2015

Member

Thanks! @parkr -- this-- in reference to my emails this afternoon.

Member

jaybe-jekyll replied Sep 24, 2015

Thanks! @parkr -- this-- in reference to my emails this afternoon.

This comment has been minimized.

Show comment
Hide comment

This comment has been minimized.

Show comment
Hide comment
@tomjoht

tomjoht Sep 24, 2015

Contributor
Contributor

tomjoht replied Sep 24, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.