New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added permalink time variables #3990

Merged
merged 1 commit into from Sep 24, 2015

Conversation

Projects
None yet
6 participants
@pheuko
Contributor

pheuko commented Sep 23, 2015

This is the solution that I thought for issue #3978.

You just need to configure your permalink with the new timestamp variable and put the time in the document's filename.

You can also override the date via the document's YAML front matter but don't forget about your environment timezone.

Is this what you were talking about?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 23, 2015

Contributor

I'm just gonna say this is one of the most complete pull requests I've seen in a long time. 👍 and :shipit:

Contributor

envygeeks commented Sep 23, 2015

I'm just gonna say this is one of the most complete pull requests I've seen in a long time. 👍 and :shipit:

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 23, 2015

Contributor

Thank you @envygeeks

Contributor

pheuko commented Sep 23, 2015

Thank you @envygeeks

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 23, 2015

Member

Nice work, @pheuko! People might want to customize this, though, which I would prefer we avoid. Would it be better to just add the three levels of time and support that?

Member

parkr commented Sep 23, 2015

Nice work, @pheuko! People might want to customize this, though, which I would prefer we avoid. Would it be better to just add the three levels of time and support that?

@parkr parkr added the Enhancement label Sep 23, 2015

@jaybe-jekyll

This comment has been minimized.

Show comment
Hide comment
@jaybe-jekyll

jaybe-jekyll Sep 23, 2015

Member

This is nice. Thanks for disabling the regex capture of the added valid post name regex. ?: :)

Member

jaybe-jekyll commented Sep 23, 2015

This is nice. Thanks for disabling the regex capture of the added valid post name regex. ?: :)

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 23, 2015

Contributor

Yes, custom time will be better. Hour, minute and second, right? I will change to this.

Contributor

pheuko commented Sep 23, 2015

Yes, custom time will be better. Hour, minute and second, right? I will change to this.

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 23, 2015

Contributor
Contributor

pheuko commented Sep 23, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 23, 2015

Member

Yes, custom time will be better. Hour, minute and second, right? I will change to this.

Yes! :hour, :minute, :seconds and the corresponding tests & docs. You da 💣, thanks!

Member

parkr commented Sep 23, 2015

Yes, custom time will be better. Hour, minute and second, right? I will change to this.

Yes! :hour, :minute, :seconds and the corresponding tests & docs. You da 💣, thanks!

@pheuko pheuko changed the title from Added permalink timestamp variable to Added permalink time variables Sep 23, 2015

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 23, 2015

Contributor

I just updated my PR with time variables and created an example about the timestamp permalink. Surely is much more customizable, please check if it is ok.

Contributor

pheuko commented Sep 23, 2015

I just updated my PR with time variables and created an example about the timestamp permalink. Surely is much more customizable, please check if it is ok.

Show outdated Hide outdated lib/jekyll/post.rb
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 23, 2015

Member

Change to the post filename is out of scope but everything else looks good. Please revert the MATCHER change and related docs/tests.

Thanks!

Member

parkr commented Sep 23, 2015

Change to the post filename is out of scope but everything else looks good. Please revert the MATCHER change and related docs/tests.

Thanks!

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 23, 2015

Contributor

Ok

Contributor

pheuko commented Sep 23, 2015

Ok

@pheuko

This comment has been minimized.

Show comment
Hide comment
@pheuko

pheuko Sep 24, 2015

Contributor

Reverting the MATCHER this PR becomes really simple. =)

Contributor

pheuko commented Sep 24, 2015

Reverting the MATCHER this PR becomes really simple. =)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr commented Sep 24, 2015

:shipit:

envygeeks added a commit that referenced this pull request Sep 24, 2015

@envygeeks envygeeks merged commit e01c40f into jekyll:master Sep 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

❤️

Contributor

envygeeks commented Sep 24, 2015

❤️

@Fastidious

This comment has been minimized.

Show comment
Hide comment
@Fastidious

Fastidious Sep 29, 2015

Was this implemented? Running jekyll 3.0.0.pre.beta9 and I am getting literal :hour:minute on the permalink, when using:

permalink: /:year:month:day:hour:minute

Fastidious commented Sep 29, 2015

Was this implemented? Running jekyll 3.0.0.pre.beta9 and I am getting literal :hour:minute on the permalink, when using:

permalink: /:year:month:day:hour:minute

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 30, 2015

Member

@Fastidious It's in master – i don't believe it made it to beta9.

Member

parkr commented Sep 30, 2015

@Fastidious It's in master – i don't believe it made it to beta9.

@Fastidious

This comment has been minimized.

Show comment
Hide comment
@Fastidious

Fastidious Sep 30, 2015

@parkr a gem install jekyll Is giving me 2.5.3, how do I go about getting master with gem?

Fastidious commented Sep 30, 2015

@parkr a gem install jekyll Is giving me 2.5.3, how do I go about getting master with gem?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 30, 2015

Contributor

@Fastidious you can't gem install master, you either need to use our master docker image or you need to use a Gemfile and tell it to pull github source and install it.

Contributor

envygeeks commented Sep 30, 2015

@Fastidious you can't gem install master, you either need to use our master docker image or you need to use a Gemfile and tell it to pull github source and install it.

@Fastidious

This comment has been minimized.

Show comment
Hide comment
@Fastidious

Fastidious Sep 30, 2015

@envygeeks how long it takes for the changes in master to make it to RubyGems?

Fastidious commented Sep 30, 2015

@envygeeks how long it takes for the changes in master to make it to RubyGems?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 30, 2015

Contributor

I'll ping @parkr and ask him to release.

Contributor

envygeeks commented Sep 30, 2015

I'll ping @parkr and ask him to release.

@Fastidious

This comment has been minimized.

Show comment
Hide comment
@Fastidious

Fastidious commented Oct 23, 2015

@envygeeks was @parkr pinged?

@parkr

This comment has been minimized.

Show comment
Hide comment
@Fastidious

This comment has been minimized.

Show comment
Hide comment
@Fastidious

Fastidious commented Oct 23, 2015

@parkr, thanks!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.