Fix broken configuration documentation page #3994

Merged
merged 1 commit into from Sep 24, 2015

Conversation

Projects
None yet
4 participants
@arthurhammer
Contributor

arthurhammer commented Sep 24, 2015

No description provided.

@parkr

View changes

site/_docs/configuration.md
- {% endif %}
- {% endraw %}
-```
+{% highlight ruby %}

This comment has been minimized.

@parkr

parkr Sep 24, 2015

Member

Why did you choose ruby here? I believe this should still be Liquid.

@parkr

parkr Sep 24, 2015

Member

Why did you choose ruby here? I believe this should still be Liquid.

This comment has been minimized.

@arthurhammer

arthurhammer Sep 24, 2015

Contributor

@parkr I wasn't sure. I looked at the templates page and it used ruby and text for Liquid highlighting. Should I update?

@arthurhammer

arthurhammer Sep 24, 2015

Contributor

@parkr I wasn't sure. I looked at the templates page and it used ruby and text for Liquid highlighting. Should I update?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2015

Member

Thanks so much, @arthurhammer!

Member

parkr commented Sep 24, 2015

Thanks so much, @arthurhammer!

@arthurhammer

This comment has been minimized.

Show comment
Hide comment
@arthurhammer

arthurhammer Sep 24, 2015

Contributor

@parkr Changed it to use Liquid highlighting now.

Contributor

arthurhammer commented Sep 24, 2015

@parkr Changed it to use Liquid highlighting now.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

@arthurhammer can you please also change "bash" to "shell", while I love bash with all my heart shell is the preferred shell for simple scripts just to be sure.

Contributor

envygeeks commented Sep 24, 2015

@arthurhammer can you please also change "bash" to "shell", while I love bash with all my heart shell is the preferred shell for simple scripts just to be sure.

@arthurhammer

This comment has been minimized.

Show comment
Hide comment
@arthurhammer

arthurhammer Sep 24, 2015

Contributor

@envygeeks Will do. Should I squash these three into one commit?

Contributor

arthurhammer commented Sep 24, 2015

@envygeeks Will do. Should I squash these three into one commit?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

@arthurhammer yes, please that would be lovely.

Contributor

envygeeks commented Sep 24, 2015

@arthurhammer yes, please that would be lovely.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 24, 2015

Member

W squash, :shipit:

Member

parkr commented Sep 24, 2015

W squash, :shipit:

@arthurhammer

This comment has been minimized.

Show comment
Hide comment
@arthurhammer

arthurhammer Sep 24, 2015

Contributor

@envygeeks Change to "shell" as in {% highlight shell %}? There doesn't appear to be a shell highlighter: ClassNotFound: no lexer for alias 'shell' found.

Contributor

arthurhammer commented Sep 24, 2015

@envygeeks Change to "shell" as in {% highlight shell %}? There doesn't appear to be a shell highlighter: ClassNotFound: no lexer for alias 'shell' found.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

I think it's just sh sorry.

Contributor

envygeeks commented Sep 24, 2015

I think it's just sh sorry.

@arthurhammer

This comment has been minimized.

Show comment
Hide comment
@arthurhammer

arthurhammer Sep 24, 2015

Contributor

All should be well now, thanks!

Contributor

arthurhammer commented Sep 24, 2015

All should be well now, thanks!

envygeeks added a commit that referenced this pull request Sep 24, 2015

Merge pull request #3994 from arthurhammer/patch-1
Fix broken configuration documentation page

@envygeeks envygeeks merged commit c91b622 into jekyll:master Sep 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 24, 2015

Contributor

❤️

Contributor

envygeeks commented Sep 24, 2015

❤️

@arthurhammer arthurhammer deleted the arthurhammer:patch-1 branch Sep 24, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.