New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add header message to _config.yml #3997

Merged
merged 1 commit into from Sep 26, 2015

Conversation

Projects
None yet
4 participants
@d9n
Contributor

d9n commented Sep 26, 2015

The first thing new users to Jekyll do is open _config.yml, so this
change adds a simple welcome message to the top of it. Additionally,
it informs the user that the file is not automatically reloaded when
changed, which is a point of confusion for new users.

Related issue: #2302

Add header message to _config.yml
The first thing new users to Jekyll do is open _config.yml, so this
change adds a simple welcome message to the top of it. Additionally,
it informs the user that the file is not automatically reloaded when
changed, which is a point of confusion for new users.

Related issue: #2302
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 26, 2015

Contributor

I'm okay with it 👍

Contributor

envygeeks commented Sep 26, 2015

I'm okay with it 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 26, 2015

Member

Excellent! :shipit:

Any idea why Travis failed?

Member

parkr commented Sep 26, 2015

Excellent! :shipit:

Any idea why Travis failed?

@d9n

This comment has been minimized.

Show comment
Hide comment
@d9n

d9n Sep 26, 2015

Contributor

Hey guys,

New to Jekyll but excited to learn. Thanks for considering my patch!

No idea why I broke the tests. I'll see if I can debug it tomorrow. I
haven't done much Ruby at this point so it may take me a little while to
figure out how things are supposed to work.

David

On Fri, Sep 25, 2015 at 9:18 PM Parker Moore notifications@github.com
wrote:

Excellent! [image: :shipit:]

Any idea why Travis failed?


Reply to this email directly or view it on GitHub
#3997 (comment).

Contributor

d9n commented Sep 26, 2015

Hey guys,

New to Jekyll but excited to learn. Thanks for considering my patch!

No idea why I broke the tests. I'll see if I can debug it tomorrow. I
haven't done much Ruby at this point so it may take me a little while to
figure out how things are supposed to work.

David

On Fri, Sep 25, 2015 at 9:18 PM Parker Moore notifications@github.com
wrote:

Excellent! [image: :shipit:]

Any idea why Travis failed?


Reply to this email directly or view it on GitHub
#3997 (comment).

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 26, 2015

Contributor

Don't worry about it @d9n it happens from time to time and I just restart the test and it works, something in SafeYAML recently changed a few months back and it causes edges all over the place that I've not got around to working on.

Contributor

envygeeks commented Sep 26, 2015

Don't worry about it @d9n it happens from time to time and I just restart the test and it works, something in SafeYAML recently changed a few months back and it causes edges all over the place that I've not got around to working on.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 26, 2015

Contributor

I think I already filed a ticket to remind myself it's something I want to fix in the change to RSpec.

Contributor

envygeeks commented Sep 26, 2015

I think I already filed a ticket to remind myself it's something I want to fix in the change to RSpec.

parkr added a commit that referenced this pull request Sep 26, 2015

@parkr parkr merged commit 5a765af into jekyll:master Sep 26, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Sep 26, 2015

Contributor

❤️

Contributor

envygeeks commented Sep 26, 2015

❤️

parkr added a commit that referenced this pull request Sep 26, 2015

@d9n

This comment has been minimized.

Show comment
Hide comment
@d9n

d9n Sep 26, 2015

Contributor

Awesome, thanks guys!

On Sat, Sep 26, 2015 at 12:35 PM Jordon Bedwell notifications@github.com
wrote:

[image: ❤️]


Reply to this email directly or view it on GitHub
#3997 (comment).

Contributor

d9n commented Sep 26, 2015

Awesome, thanks guys!

On Sat, Sep 26, 2015 at 12:35 PM Jordon Bedwell notifications@github.com
wrote:

[image: ❤️]


Reply to this email directly or view it on GitHub
#3997 (comment).

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.