update plugins documentation #4013

Merged
merged 4 commits into from Oct 11, 2015

Conversation

Projects
None yet
4 participants
@antonk52
Contributor

antonk52 commented Oct 8, 2015

you have to install gem files for plugins for them in order to work

update plugins documentation
you have to install gem files for plugins for them in order to work
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 8, 2015

Contributor

I think that would be nicer as point 3, would you mind making it it's own point on the list rather than an addition onto point 2?

Contributor

envygeeks commented Oct 8, 2015

I think that would be nicer as point 3, would you mind making it it's own point on the list rather than an addition onto point 2?

@antonk52

This comment has been minimized.

Show comment
Hide comment
@antonk52

antonk52 Oct 8, 2015

Contributor

perhaps it may make more sense as a sub point to point 2, as it is not a separate way to use a plugin you want to install. To use a plugin you have to install a gem and specify the name in the config. Therefore, it it should be in one point

Contributor

antonk52 commented Oct 8, 2015

perhaps it may make more sense as a sub point to point 2, as it is not a separate way to use a plugin you want to install. To use a plugin you have to install a gem and specify the name in the config. Therefore, it it should be in one point

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 8, 2015

Contributor

Let me rephrase what I said: It's it's own step.

Contributor

envygeeks commented Oct 8, 2015

Let me rephrase what I said: It's it's own step.

@antonk52

This comment has been minimized.

Show comment
Hide comment
@antonk52

antonk52 Oct 8, 2015

Contributor

Maybe I did not phrase it write, as jekyll offers you 3 options how to install a plugin, installing a gem will be a part of option 2, isn't it? This is why it should not be a separate point

Contributor

antonk52 commented Oct 8, 2015

Maybe I did not phrase it write, as jekyll offers you 3 options how to install a plugin, installing a gem will be a part of option 2, isn't it? This is why it should not be a separate point

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 8, 2015

Contributor

I think we are both lost in translation here, I did not fully read that page and it seems we both missed point 3. Since this applies to both point 2 and point 3 it should be a sub-note outside of all those notes (right outside of it.) I do apologize for not reading the entire page before commenting.

Contributor

envygeeks commented Oct 8, 2015

I think we are both lost in translation here, I did not fully read that page and it seems we both missed point 3. Since this applies to both point 2 and point 3 it should be a sub-note outside of all those notes (right outside of it.) I do apologize for not reading the entire page before commenting.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 8, 2015

Contributor

Let me elaborate, instead of putting it on 2 or 3, put it under all of the points as a _note_ so that people see it at the bottom since it would be pretty hard not to grep that when reading the page.

Contributor

envygeeks commented Oct 8, 2015

Let me elaborate, instead of putting it on 2 or 3, put it under all of the points as a _note_ so that people see it at the bottom since it would be pretty hard not to grep that when reading the page.

Update plugins.md
Note to option 2 and 3 for installing plugins
@antonk52

This comment has been minimized.

Show comment
Hide comment
@antonk52

antonk52 Oct 8, 2015

Contributor

It is okay, communication can be difficult at times. I have updated my patch by taking the note outside the list of options.

Contributor

antonk52 commented Oct 8, 2015

It is okay, communication can be difficult at times. I have updated my patch by taking the note outside the list of options.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 8, 2015

Member

I think this block is confusing in general, because it says they are ways of installing jekyll plugins, though none of them actually do that. They're more a way of enabling them in your site. In point 1, no gem install is required, point 2 required gem install, and point 3 requires bundle install. So maybe points 2 and 3 need their own "Then, run CMD." at the end.

Member

parkr commented Oct 8, 2015

I think this block is confusing in general, because it says they are ways of installing jekyll plugins, though none of them actually do that. They're more a way of enabling them in your site. In point 1, no gem install is required, point 2 required gem install, and point 3 requires bundle install. So maybe points 2 and 3 need their own "Then, run CMD." at the end.

Update plugins.md
Added gem install and bundle install commands for plugins set up
@antonk52

This comment has been minimized.

Show comment
Hide comment
@antonk52

antonk52 Oct 8, 2015

Contributor

I agree on the confusing part, I have edited my patch.

Contributor

antonk52 commented Oct 8, 2015

I agree on the confusing part, I have edited my patch.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 8, 2015

Member

Can you run bundle exec rake site:preview and fix the source until this looks right?

screen shot 2015-10-08 at 3 33 34 pm

Member

parkr commented Oct 8, 2015

Can you run bundle exec rake site:preview and fix the source until this looks right?

screen shot 2015-10-08 at 3 33 34 pm

Update plugins.md
Corrected display of installing options
@antonk52

This comment has been minimized.

Show comment
Hide comment
@antonk52

antonk52 Oct 11, 2015

Contributor

The latest edit is what you meant, right?

Contributor

antonk52 commented Oct 11, 2015

The latest edit is what you meant, right?

@parkr parkr closed this in 3eb2521 Oct 11, 2015

parkr added a commit that referenced this pull request Oct 11, 2015

@parkr parkr merged commit fa2c8d2 into jekyll:master Oct 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 11, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.