Fix pretty permalink example #4029

Merged
merged 1 commit into from Oct 15, 2015

Conversation

Projects
None yet
4 participants
@MonsieurV
Contributor

MonsieurV commented Oct 14, 2015

Following what the documentation specifies above for the pretty permalink format (/:categories/:year/:month/:day/:title/), it should result for the example to /2009/04/29/slap-chop/ and not /2009/04/29/slap-chop/index.html. Well, at least if I've understood correctly ;-)

Fix pretty permalink example
Following what the documentation specify above for the pretty permalink format (`/:categories/:year/:month/:day/:title/`), it should result for the example to `/2009/04/29/slap-chop/` and not `/2009/04/29/slap-chop/index.html`. Well, at least if I've understood correctly ;-)
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 14, 2015

Contributor

The file exists so technically it's right, but given your need to be highly technical even your example is wrong because it would be a directory and you removed the trailing slash. I'm neutral (but 👍) on this.

Contributor

envygeeks commented Oct 14, 2015

The file exists so technically it's right, but given your need to be highly technical even your example is wrong because it would be a directory and you removed the trailing slash. I'm neutral (but 👍) on this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 15, 2015

Member

The example points to the file, not to the permalink, so 👍

Member

parkr commented Oct 15, 2015

The example points to the file, not to the permalink, so 👍

parkr added a commit that referenced this pull request Oct 15, 2015

@parkr parkr merged commit 8fec927 into jekyll:master Oct 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 15, 2015

@MonsieurV MonsieurV deleted the MonsieurV:patch-1 branch Oct 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.