New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a constant for the regex to find hidden files #4032

Merged
merged 1 commit into from Oct 17, 2015

Conversation

Projects
None yet
4 participants
@mattr-
Member

mattr- commented Oct 16, 2015

A raw regular expression isn't very expressive, IMHO. Rather than having people who read this code parse the regular expression to figure out what it's for, let's give a name. This way, it becomes more obvious what exactly it is we're doing here.

This was something that I saw when I was working on #4011 that I didn't want to change in that PR but did want to come back to and change later.

Make a constant for the regex to find hidden files
A raw regular expression isn't very expressive, IMHO. Rather than having
people who read this code parse the regular expression to figure out
what it's for, let's give a name. This way, it becomes more obvious what
exactly it is we're doing here.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 17, 2015

Member

LGTM! :shipit:

Member

parkr commented Oct 17, 2015

LGTM! :shipit:

envygeeks added a commit that referenced this pull request Oct 17, 2015

Merge pull request #4032 from jekyll/refactor-cleaner-for-expressiveness
Make a constant for the regex to find hidden files

@envygeeks envygeeks merged commit 271dc42 into master Oct 17, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the refactor-cleaner-for-expressiveness branch Oct 17, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.