New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore `.bundle` when generating test coverage #4033

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@mattr-
Member

mattr- commented Oct 16, 2015

Fix the code coverage reporting when using .bundle to store my gems in by having SimpleCov ignore that directory. Use of .bundle to store my gems consolidates things since since that directory also holds the bundler config file. It also keeps a vendor directory out of the project tree for non-Rails projects. Simplecov was not ignoring that directory though, which meant that the code coverage numbers I were seeing locally were wrong (and very frightening). With this change, all is right with the world once again. 馃槂

Ignore `.bundle` when generating test coverage
Fix the code coverage reporting when using `.bundle` to store my gems in
by having SimpleCov ignore that directory. Use of `.bundle` to store my
gems consolidates things since since that directory also holds the
bundler config file. It also keeps a `vendor` directory out of the
project tree for non-Rails projects.  Simplecov was not ignoring that
directory though, which meant that the code coverage numbers I were
seeing locally were wrong (and very frightening). With this change, all
is right with the world once again. 馃槂

envygeeks added a commit that referenced this pull request Oct 16, 2015

Merge pull request #4033 from jekyll/ignore-more-bundler-directories
Ignore `.bundle` when generating test coverage

@envygeeks envygeeks merged commit 84089f9 into master Oct 16, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 16, 2015

Contributor

I forgot to 鉂わ笍 thank you when I merged, silly merge script.

Contributor

envygeeks commented Oct 16, 2015

I forgot to 鉂わ笍 thank you when I merged, silly merge script.

@parkr parkr deleted the ignore-more-bundler-directories branch Oct 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.