New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage.md re: _config.yml not reloaded during regeneration #4034

Merged
merged 1 commit into from Oct 16, 2015

Conversation

Projects
None yet
3 participants
@jaybe-jekyll
Member

jaybe-jekyll commented Oct 16, 2015

_config.yml not reloaded during automatic regeneration

Update usage.md re: _config.yml not reloaded during automatic regener…
…ation

_config.yml not reloaded during automatic regeneration
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 16, 2015

Contributor

Any reason for the brackets around _config.yml?

Contributor

envygeeks commented Oct 16, 2015

Any reason for the brackets around _config.yml?

@jaybe-jekyll

This comment has been minimized.

Show comment
Hide comment
@jaybe-jekyll

jaybe-jekyll Oct 16, 2015

Member

Purpose was to call out as special; i.e. code, file, path, etc. I modeled styling off of block below; I see now the brackets are being used for variables and directives and not files.

To style or not to style; that is the question. Let me know your thoughts and I'll adjust.

Member

jaybe-jekyll commented Oct 16, 2015

Purpose was to call out as special; i.e. code, file, path, etc. I modeled styling off of block below; I see now the brackets are being used for variables and directives and not files.

To style or not to style; that is the question. Let me know your thoughts and I'll adjust.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 16, 2015

Contributor

I'm not against it. I'll merge and if there are complaints we can go back and correct it.

Contributor

envygeeks commented Oct 16, 2015

I'm not against it. I'll merge and if there are complaints we can go back and correct it.

envygeeks added a commit that referenced this pull request Oct 16, 2015

Merge pull request #4034 from jaybe-jekyll/patch-1
Update usage.md re: _config.yml not reloaded during regeneration

@envygeeks envygeeks merged commit 18bdfac into jekyll:master Oct 16, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jaybe-jekyll

This comment has been minimized.

Show comment
Hide comment
@jaybe-jekyll

jaybe-jekyll Oct 16, 2015

Member

Looking at where and how _config.yml has been referenced throughout the documentation, it is referenced as:

<code>_config.yml</code>

I would prefer to adjust and recommit with consistent style and approach.

Member

jaybe-jekyll commented Oct 16, 2015

Looking at where and how _config.yml has been referenced throughout the documentation, it is referenced as:

<code>_config.yml</code>

I would prefer to adjust and recommit with consistent style and approach.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 16, 2015

Contributor

If you wish you can submit another pull and we can merge it without a history mark, otherwise I'll correct it later this afternoon after I get done working on some stuff.

Contributor

envygeeks commented Oct 16, 2015

If you wish you can submit another pull and we can merge it without a history mark, otherwise I'll correct it later this afternoon after I get done working on some stuff.

@jaybe-jekyll jaybe-jekyll deleted the jaybe-jekyll:patch-1 branch Oct 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.