New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the highlight class #4046

Merged
merged 1 commit into from Oct 19, 2015

Conversation

Projects
None yet
4 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Oct 19, 2015

See comments in #3940.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 19, 2015

Contributor

OH: I was the one who requested that, well I'll stick to what I requested. I'm 👍

Contributor

envygeeks commented Oct 19, 2015

OH: I was the one who requested that, well I'll stick to what I requested. I'm 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 19, 2015

Member

What about backtick code blocks? If those work on the site, then they'll be cross-compatible.

Member

parkr commented Oct 19, 2015

What about backtick code blocks? If those work on the site, then they'll be cross-compatible.

@parkr parkr added the Documentation label Oct 19, 2015

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Oct 19, 2015

Contributor

Either way you guys would like is fine. The other style (say on the Posts page) is visually distinct, but does seem "heavy" given that there are multiple lines where it would be applied. Examples are as follows:

Backticks:

screen shot 2015-10-18 at 11 22 54 pm

CSS w/ the "highlight" class:

screen shot 2015-10-18 at 11 30 49 pm

Contributor

chrisfinazzo commented Oct 19, 2015

Either way you guys would like is fine. The other style (say on the Posts page) is visually distinct, but does seem "heavy" given that there are multiple lines where it would be applied. Examples are as follows:

Backticks:

screen shot 2015-10-18 at 11 22 54 pm

CSS w/ the "highlight" class:

screen shot 2015-10-18 at 11 30 49 pm

parkr added a commit that referenced this pull request Oct 19, 2015

@parkr parkr merged commit 4e01722 into jekyll:master Oct 19, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 19, 2015

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:style-the-test-code branch Oct 19, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.