New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default font weight to 400 to fix bold/strong text issues #4050

Merged
merged 1 commit into from Oct 22, 2015

Conversation

Projects
None yet
4 participants
@alfredxing
Member

alfredxing commented Oct 22, 2015

Change default font weight in site template to 400 (normal), except for the site title, which remains at 300.
Should fix #4042.

Not sure if we're still going for #3921 though.

/cc @jekyll/core

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 22, 2015

Contributor

I'm 👍 if we just remove the font-weight entirely. At the point of setting it to 400 by default we can just remove it since 400 is the default across all so it will just be normal, no need to be explicit about normal when normal is normal because it's normally normal.

Contributor

envygeeks commented Oct 22, 2015

I'm 👍 if we just remove the font-weight entirely. At the point of setting it to 400 by default we can just remove it since 400 is the default across all so it will just be normal, no need to be explicit about normal when normal is normal because it's normally normal.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Oct 22, 2015

Member

I thought that as well, but I left it in there in case users want to change/customize theirs (perhaps back to 300 if they're not worried about the bug).

Member

alfredxing commented Oct 22, 2015

I thought that as well, but I left it in there in case users want to change/customize theirs (perhaps back to 300 if they're not worried about the bug).

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 22, 2015

Contributor

That's makes sense, and in light of that sensibility I say :shipit:

Contributor

envygeeks commented Oct 22, 2015

That's makes sense, and in light of that sensibility I say :shipit:

parkr added a commit that referenced this pull request Oct 22, 2015

@parkr parkr merged commit ae993cb into jekyll:master Oct 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 22, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 22, 2015

Contributor

❤️

Contributor

envygeeks commented Oct 22, 2015

❤️

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 22, 2015

Contributor

I can't spell heart today, and it's breaking my heart.

Contributor

envygeeks commented Oct 22, 2015

I can't spell heart today, and it's breaking my heart.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 22, 2015

Member

Haha. :)

Member

parkr commented Oct 22, 2015

Haha. :)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.