Add Document#method_missing and Collection#method_missing #4058

Merged
merged 1 commit into from Oct 26, 2015

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Oct 26, 2015

Proxies calls to either #data or #docs, respectively. Deprecation warning is printed.

screen shot 2015-10-26 at 1 37 17 pm

Don't break, deprecate.

Add Document#method_missing and Collection#method_missing
Proxies calls to either #data or #docs, respectively. Deprecation warning is printed.
@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 26, 2015

Contributor

It does the job, I like it! Well, at least until it's ready to be put to pasture.

Contributor

envygeeks commented Oct 26, 2015

It does the job, I like it! Well, at least until it's ready to be put to pasture.

@parkr parkr added this to the 3.0 milestone Oct 26, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 26, 2015

Member

Failure is jruby. Merging.

Member

parkr commented Oct 26, 2015

Failure is jruby. Merging.

parkr added a commit that referenced this pull request Oct 26, 2015

@parkr parkr merged commit 8738a66 into master Oct 26, 2015

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr deleted the method_missing_madness branch Oct 26, 2015

parkr added a commit that referenced this pull request Oct 26, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.