Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG support to Jekyll/Webrick #407

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@envygeeks
Copy link
Contributor

envygeeks commented Sep 25, 2011

Fixes: #406
Signed-off-by: Jordon Bedwell jordon@envygeeks.com

Jordon Bedwell
Add SVG mimetype according to RFC3023
Fixes: #406
Signed-off-by: Jordon Bedwell <jordon@envygeeks.com>

@envygeeks envygeeks closed this Jan 22, 2012

@adius

This comment has been minimized.

Copy link

adius commented Nov 19, 2012

Could you please merge this pull request! That's such a fundamental bug!
10 Month old already! ...unbelievable!

@ronaldroe

This comment has been minimized.

Copy link

ronaldroe commented Nov 20, 2012

2nd that!

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Nov 25, 2012

I'm preparing a branch of jekyll with things that I believe would be appropriate for merging into a new version of jekyll (and then eventually asking to have it pulled). I've included this fix there.

@envygeeks

This comment has been minimized.

Copy link
Contributor Author

envygeeks commented Jan 24, 2013

Pinging @parkr so he is aware this is still an issue too and will be in the loop.

parkr added a commit that referenced this pull request Jan 25, 2013

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jan 25, 2013

Merged!

@christian-fei

This comment has been minimized.

Copy link

christian-fei commented Mar 27, 2013

Hey I'm still having this issue, but strangely enough only when I'm developing local O.o
Does someone know a fix for that ? Would be great :)

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 27, 2013

What version of Jekyll are you using?

@envygeeks

This comment has been minimized.

Copy link
Contributor Author

envygeeks commented Mar 27, 2013

Since it happens in production and not in development that makes me wonder if there isn't a problem with the production server, since the SVG fix here was for webrick that could be the difference if you aren't using webrick.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 27, 2013

It's the other way around @envygeeks :-)

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 27, 2013

@christian-fei Should have been fixed in 1.0.0.beta2!

@envygeeks

This comment has been minimized.

Copy link
Contributor Author

envygeeks commented Mar 27, 2013

oh man I am so bad at reading, sorry I got confused :( been a busy day.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 27, 2013

:-)

@christian-fei

This comment has been minimized.

Copy link

christian-fei commented Mar 27, 2013

WOW! thanks for all the fast replies! :)
I have jekyll 0.12.1 , now executed gem install jekyll --pre and will report how it goes!

@christian-fei

This comment has been minimized.

Copy link

christian-fei commented Mar 27, 2013

YO! Works now, like a charm!
I'm new to jekyll, so many thanks for giving me a heads up :)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.