GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/cc @benbalter @fw42 @jekyll/core
Should probably add a regression test for this
@fw42 great idea.
I found the errors in the templates helpful, too... But I guess terminal errors would be better because they'd break the build which is what we want when something goes wrong.
LGTM pending the regression test. A cucumber test will suffice.
I'll add the test after I finish up with my other pull requests.
Fix #4066: Move Convertible#render_liquid to using render!
Add regression tests to Cucumber.
It took a while to write that test, it was crazy because I couldn't figure out why it wasn't getting output and it turned out there might be a slight bug in POSIX::Spawn::Child somewhere.
I would have just tested that render_liquid doesn't swallow exceptions, but I guess this works too
I considered that, but then I decided that we want the errors to bubble at the UX so tested it in Cucumber.
Merge pull request #4077 from jekyll/fix_render
Merge pull request 4077
Update history to reflect merge of #4077