New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Font Awesome to v4.4.0. #4086

Merged
merged 1 commit into from Oct 30, 2015

Conversation

Projects
None yet
5 participants
@XhmikosR
Contributor

XhmikosR commented Oct 30, 2015

Mostly for .woff2 support.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 30, 2015

Member

👍

Member

parkr commented Oct 30, 2015

👍

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2015

Contributor

I'm hesitant on this one, double check the SHA's before merging the binary files.

Contributor

envygeeks commented Oct 30, 2015

I'm hesitant on this one, double check the SHA's before merging the binary files.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Oct 30, 2015

Contributor

Come on, guys, I'm not new on this.

Contributor

XhmikosR commented Oct 30, 2015

Come on, guys, I'm not new on this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 30, 2015

Member

We could have a SHA check built-into the rake task if we wanted. I kinda wish GitHub printed out a hash fingerprint so we could instantly verify...

Member

parkr commented Oct 30, 2015

We could have a SHA check built-into the rake task if we wanted. I kinda wish GitHub printed out a hash fingerprint so we could instantly verify...

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2015

Contributor

@XhmikosR it's not that we think you are new, it's that we have to provide our own integrity so we need to verify the validity of things like that before we update them (at least that's my 0.02c) I don't know if @jekyll/core agrees.

Contributor

envygeeks commented Oct 30, 2015

@XhmikosR it's not that we think you are new, it's that we have to provide our own integrity so we need to verify the validity of things like that before we update them (at least that's my 0.02c) I don't know if @jekyll/core agrees.

Update Font Awesome to v4.4.0.
Mostly for .woff2 support.
@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Oct 30, 2015

Contributor

You can verify it if you really want, but seriously, you are barking at the wrong tree here.

Just check who updated it last time too.

Contributor

XhmikosR commented Oct 30, 2015

You can verify it if you really want, but seriously, you are barking at the wrong tree here.

Just check who updated it last time too.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2015

Contributor

I'm not asking you to verify, I will happily verify when I have time unless somebody else does it before me. There is no need to be defensive, nobody is saying you are going to do anything but I am saying we need to verify that everything is in order because fonts are a vector too.

Contributor

envygeeks commented Oct 30, 2015

I'm not asking you to verify, I will happily verify when I have time unless somebody else does it before me. There is no need to be defensive, nobody is saying you are going to do anything but I am saying we need to verify that everything is in order because fonts are a vector too.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Oct 30, 2015

Member

@envygeeks Just verified the SHA1 hashes, matches fonts downloaded from FontAwesome.

Member

alfredxing commented Oct 30, 2015

@envygeeks Just verified the SHA1 hashes, matches fonts downloaded from FontAwesome.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Oct 30, 2015

Contributor

:shipit:

Contributor

envygeeks commented Oct 30, 2015

:shipit:

alfredxing added a commit that referenced this pull request Oct 30, 2015

@alfredxing alfredxing merged commit 16844d1 into jekyll:master Oct 30, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

alfredxing added a commit that referenced this pull request Oct 30, 2015

@XhmikosR XhmikosR deleted the XhmikosR:site-font-awesome branch Oct 31, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.