New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the warning #4114

Merged
merged 1 commit into from Nov 6, 2015

Conversation

Projects
None yet
5 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Nov 5, 2015

Think this should be site.posts.docs instead. Does it need a test? - works with jekyllrb.com and script/cibuild passed locally.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 6, 2015

Contributor

It doesn't need a test but it does need a narrow commit message please!

Contributor

envygeeks commented Nov 6, 2015

It doesn't need a test but it does need a narrow commit message please!

@sondr3

This comment has been minimized.

Show comment
Hide comment
@sondr3

sondr3 Nov 6, 2015

Contributor

I guess this is the fix for this warning or?

Deprecation: Collection#each should be called on the #docs array directly.
             Called by /usr/local/lib/ruby/gems/2.2.0/gems/jekyll-3.0.0/lib/jekyll/commands/doctor.rb:81:in `collect_urls'.
Contributor

sondr3 commented Nov 6, 2015

I guess this is the fix for this warning or?

Deprecation: Collection#each should be called on the #docs array directly.
             Called by /usr/local/lib/ruby/gems/2.2.0/gems/jekyll-3.0.0/lib/jekyll/commands/doctor.rb:81:in `collect_urls'.
@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Nov 6, 2015

Contributor

@sondr3 Correct.

Contributor

chrisfinazzo commented Nov 6, 2015

@sondr3 Correct.

@envygeeks envygeeks added the needs-work label Nov 6, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 6, 2015

Member

@chrisfinazzo Please rephrase the commit message. Something like "Fix the deprecation warning in the doctor command" would work just fine. Thanks!

Member

parkr commented Nov 6, 2015

@chrisfinazzo Please rephrase the commit message. Something like "Fix the deprecation warning in the doctor command" would work just fine. Thanks!

envygeeks added a commit that referenced this pull request Nov 6, 2015

Merge pull request #4114 from chrisfinazzo/fix-deprecation-warning
Fix the deprecation warning in the doctor command

@envygeeks envygeeks merged commit e43db41 into jekyll:master Nov 6, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@envygeeks envygeeks removed the needs-work label Nov 6, 2015

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:fix-deprecation-warning branch Nov 7, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.