New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tag should accept multiple variables in the include name #4183

Merged
merged 1 commit into from Nov 25, 2015

Conversation

Projects
None yet
4 participants
@rebornix
Member

rebornix commented Nov 25, 2015

I'm playing around Ruby regex these days and happen to see #4028 , this PR gives it a quick fix.

@envygeeks might have a big refactor of Jekyll own tags referring to what he mentioned in #4028 , so it's ok if this doesn't get merged.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 25, 2015

Member

I'm OK with this change.

Member

parkr commented Nov 25, 2015

I'm OK with this change.

@parkr parkr added the Enhancement label Nov 25, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 25, 2015

Contributor

Yeah, because the as is already documented we still have some work to do on our Liquid processing which is slightly more powerful but has a few quirks so the pull for my larger refactor of our tags to make every tag in (including user tags) easier won't land until jekyll-assets stabilizes it's liquid processing on tag arguments.

Contributor

envygeeks commented Nov 25, 2015

Yeah, because the as is already documented we still have some work to do on our Liquid processing which is slightly more powerful but has a few quirks so the pull for my larger refactor of our tags to make every tag in (including user tags) easier won't land until jekyll-assets stabilizes it's liquid processing on tag arguments.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Nov 25, 2015

Contributor

I vote :shipit: because it could be 3.2 3.3 before that refactor even lands.

Contributor

envygeeks commented Nov 25, 2015

I vote :shipit: because it could be 3.2 3.3 before that refactor even lands.

parkr added a commit that referenced this pull request Nov 25, 2015

@parkr parkr merged commit 4359dba into jekyll:master Nov 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 25, 2015

@parkr parkr changed the title from Allow users to input multiple variables in include tag to Include tag should accept multiple variables in the include name Nov 25, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.