New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract title from filename successfully when no date. #4195

Merged
merged 16 commits into from Jan 22, 2016

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Nov 28, 2015

PR automatically created for @envygeeks .
Closes #4191 with a slight cleanup Document#post_read.

@envygeeks envygeeks changed the title from Bug fix: extract title from filename successfully when filename is dateless. to Extract title from filename successfully when filename is dateless. Nov 28, 2015

@envygeeks envygeeks changed the title from Extract title from filename successfully when filename is dateless. to Extract title from filename successfully when no date. Nov 28, 2015

Show outdated Hide outdated lib/jekyll/document.rb
if generate_excerpt?
data['excerpt'] ||= Jekyll::Excerpt.new(self)
elsif DATELESS_FILENAME_MATCHER =~ relative_path
cats, slug, ext = $1, $2, $3

This comment has been minimized.

@parkr

parkr Nov 29, 2015

Member

@envygeeks Where do you merge this data? Did you mean to put the slug in merge_data!?

@parkr

parkr Nov 29, 2015

Member

@envygeeks Where do you merge this data? Did you mean to put the slug in merge_data!?

This comment has been minimized.

@envygeeks

envygeeks Nov 29, 2015

Contributor

@parkr I don't, nice catch, I meant to actually move that down like I did with the titleize.

@envygeeks

envygeeks Nov 29, 2015

Contributor

@parkr I don't, nice catch, I meant to actually move that down like I did with the titleize.

This comment has been minimized.

@parkr

parkr Nov 29, 2015

Member

I wonder how your test still passed then?

@parkr

parkr Nov 29, 2015

Member

I wonder how your test still passed then?

This comment has been minimized.

@envygeeks

envygeeks Nov 29, 2015

Contributor

@parkr that's something @rebornix and we have to answer, I'll look into that, it seems like we have gaps in the testing that need to be addressed.

@envygeeks

envygeeks Nov 29, 2015

Contributor

@parkr that's something @rebornix and we have to answer, I'll look into that, it seems like we have gaps in the testing that need to be addressed.

This comment has been minimized.

@rebornix

rebornix Nov 30, 2015

Member

I deleted the merge data line by mistake when attempting to resolve another test issue, seems it has nothing to do with it but I forgot to bring it back.

slug: Utils.slugify(data['slug']) || Utils.slugify(basename_without_ext), for url_placeholders in document.rb is stopping us from test failure. For dateless filename, I suppose basename_without_ext equals slug.

@rebornix

rebornix Nov 30, 2015

Member

I deleted the merge data line by mistake when attempting to resolve another test issue, seems it has nothing to do with it but I forgot to bring it back.

slug: Utils.slugify(data['slug']) || Utils.slugify(basename_without_ext), for url_placeholders in document.rb is stopping us from test failure. For dateless filename, I suppose basename_without_ext equals slug.

@parkr parkr added the fix label Nov 29, 2015

@parkr parkr added the needs-work label Nov 29, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 11, 2015

Member

Needs a rebase and to have the above problem addressed.

Member

parkr commented Dec 11, 2015

Needs a rebase and to have the above problem addressed.

@envygeeks envygeeks added this to the 3.1 milestone Dec 12, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 12, 2015

Contributor

Attaching it to 3.1 so I get a reminder to work on it before the release date.

Contributor

envygeeks commented Dec 12, 2015

Attaching it to 3.1 so I get a reminder to work on it before the release date.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 17, 2015

Contributor

Hulk: +backlog +jekyll +v3.1

Contributor

envygeeks commented Dec 17, 2015

Hulk: +backlog +jekyll +v3.1

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 27, 2015

Member

This needs a rebase, now.

Member

parkr commented Dec 27, 2015

This needs a rebase, now.

@jekyllbot jekyllbot closed this Jan 14, 2016

@parkr parkr reopened this Jan 14, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 15, 2016

Member

@envygeeks This look OK to you?

Member

parkr commented Jan 15, 2016

@envygeeks This look OK to you?

@parkr parkr assigned parkr and unassigned envygeeks Jan 19, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 22, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Jan 22, 2016

@jekyllbot: merge +bug

jekyllbot added a commit that referenced this pull request Jan 22, 2016

@jekyllbot jekyllbot merged commit ccb3826 into master Jan 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/cleanup-document__post_read branch Jan 22, 2016

jekyllbot added a commit that referenced this pull request Jan 22, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.