New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convertible should make layout data accessible via 'layout' Not via 'page'. Erroneous! Fixes #4117. #4205

Merged
merged 1 commit into from Dec 1, 2015

Conversation

Projects
None yet
4 participants
@jekyllbot
Contributor

jekyllbot commented Nov 30, 2015

PR automatically created for @parkr.

Convertible should make layout data accessible via 'layout'

Not via 'page'. Erroneous!

Fixes #4117.

@parkr parkr added the fix label Nov 30, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr commented Nov 30, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 1, 2015

Contributor

That was an easy fix, 👍

Contributor

envygeeks commented Dec 1, 2015

That was an easy fix, 👍

parkr added a commit that referenced this pull request Dec 1, 2015

@parkr parkr merged commit 4890cec into master Dec 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the pull/fix-layout-vs-page-data branch Dec 1, 2015

@parkr parkr added this to the 3.1 milestone Dec 1, 2015

parkr added a commit that referenced this pull request Dec 1, 2015

@nasht00

This comment has been minimized.

Show comment
Hide comment
@nasht00

nasht00 Jan 28, 2016

Contributor

I wonder if this is related to my issue #4414

Contributor

nasht00 commented Jan 28, 2016

I wonder if this is related to my issue #4414

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.