New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'sample' Liquid filter Equivalent to Array#sample functionality #4223

Merged
merged 5 commits into from Dec 4, 2015

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Dec 4, 2015

PR automatically created for @parkr.

Add 'sample' Liquid filter

Equivalent to Array#sample functionality

parkr added some commits Dec 4, 2015

Add 'sample' Liquid filter
Equivalent to Array#sample functionality
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 4, 2015

Member

Closes #4156. Closes #1890.

Member

parkr commented Dec 4, 2015

Closes #4156. Closes #1890.

@parkr parkr added the Enhancement label Dec 4, 2015

@parkr parkr added this to the 3.1 milestone Dec 4, 2015

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Dec 4, 2015

Member

👍

Member

alfredxing commented Dec 4, 2015

👍

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 4, 2015

Contributor

You can also:

matrix:
  fast_finish: true

Which should pass the status quicker because it will skip waiting for allowed_failures to finish.

Contributor

envygeeks commented on 0aa3c96 Dec 4, 2015

You can also:

matrix:
  fast_finish: true

Which should pass the status quicker because it will skip waiting for allowed_failures to finish.

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 4, 2015

Member

I will do that, too. Thanks!

Member

parkr replied Dec 4, 2015

I will do that, too. Thanks!

This comment has been minimized.

Show comment
Hide comment
@parkr
Member

parkr replied Dec 4, 2015

parkr added a commit that referenced this pull request Dec 4, 2015

@parkr parkr merged commit c6255d5 into master Dec 4, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr deleted the pull/sample-filter branch Dec 4, 2015

parkr added a commit that referenced this pull request Dec 4, 2015

This was referenced Dec 4, 2015

@doktorbro

This comment has been minimized.

Show comment
Hide comment
@doktorbro

doktorbro Dec 5, 2015

Member

Great. Thank you.

Member

doktorbro commented Dec 5, 2015

Great. Thank you.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.