General improvements for WEBrick via jekyll serve #4224

Merged
merged 1 commit into from Dec 4, 2015

Conversation

Projects
None yet
3 participants
@jekyllbot
Contributor

jekyllbot commented Dec 4, 2015

PR automatically created for @envygeeks.

Fix #3791/#3478

  • Add support for SSL through command line switches.
  • Add suppport for file/index.html > file.html > directory.
  • Add support for custom-headers through configuration.
  • Modernize and split up the serve.
  • Add a few basic tests.

@envygeeks envygeeks changed the title from Fix #3791/#3478 * Add support for SSL through command line switches. * Add suppport for file/index.html > file.html > directory. * Add support for custom-headers through configuration. * Modernize and split up the serve. * Add a few basic tests. to Fix #3791/#3478 Dec 4, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 4, 2015

Contributor

Woah there captain bot, I think you be needing to just use the short description :P

Contributor

envygeeks commented Dec 4, 2015

Woah there captain bot, I think you be needing to just use the short description :P

@parkr parkr changed the title from Fix #3791/#3478 to General improvements for WEBrick via jekyll serve Dec 4, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 4, 2015

Member

@envygeeks I can change it so it uses just the first line of the commit message as long as it's not "Fix #XXX/#XXX" because that's not useful as a PR title :)

Member

parkr commented Dec 4, 2015

@envygeeks I can change it so it uses just the first line of the commit message as long as it's not "Fix #XXX/#XXX" because that's not useful as a PR title :)

lib/jekyll/commands/serve.rb
+
+ "ssl_key" => ["--ssl-key [KEY]", "X.509 (SSL) Private Key."],
+ "ssl_cert" => ["--ssl-cert [CERT]", "X.509 (SSL) certificate."],
+ "baseurl" => ["-b", "--baseurl [URL]", "Base URL"]

This comment has been minimized.

@parkr

parkr Dec 4, 2015

Member

We align at the =>

"open_url" => ["-o"],
"detach"   => ["-B"],
# ... etc
@parkr

parkr Dec 4, 2015

Member

We align at the =>

"open_url" => ["-o"],
"detach"   => ["-B"],
# ... etc

This comment has been minimized.

@envygeeks

envygeeks Dec 4, 2015

Contributor

Fixed.

@envygeeks

envygeeks Dec 4, 2015

Contributor

Fixed.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 4, 2015

Contributor

That's a good idea, because I used that short main message because the more described everything in more detail so I guess it would be better for it to resort to the entire thing in this case.

Contributor

envygeeks commented Dec 4, 2015

That's a good idea, because I used that short main message because the more described everything in more detail so I guess it would be better for it to resort to the entire thing in this case.

Fix #3791/#3478
* Add support for SSL through command line switches.
* Add suppport for file/index.html > file.html > directory.
* Add support for custom-headers through configuration.
* Modernize and split up the serve.
* Add a few basic tests.

@envygeeks envygeeks added this to the 3.1 milestone Dec 4, 2015

@envygeeks envygeeks self-assigned this Dec 4, 2015

parkr added a commit that referenced this pull request Dec 4, 2015

@parkr parkr merged commit 313582f into master Dec 4, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the pull/cleanup-and-modernize-serve-cmd branch Dec 4, 2015

parkr added a commit that referenced this pull request Dec 4, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 4, 2015

Member

Thank you, @envygeeks!

Member

parkr commented Dec 4, 2015

Thank you, @envygeeks!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.