New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For blessed gems, shim their commands so users know how to use them. #4254

Merged
merged 2 commits into from Jan 5, 2016

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Dec 11, 2015

Basically doing #4253 but for Jekyll 3.

@parkr parkr added this to the 3.1 milestone Dec 11, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 17, 2015

Contributor

What if we did this for all gems instead of through commands? If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"? Most of the time we can infer what the gem name is reliably from the require.

Contributor

envygeeks commented Dec 17, 2015

What if we did this for all gems instead of through commands? If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"? Most of the time we can infer what the gem name is reliably from the require.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 24, 2015

Member

If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"?

Yes, we do! Anywhere we use Jekyll::External.require_with_graceful_fail, we are doing that. This PR is for subcommands.

Member

parkr commented Dec 24, 2015

If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"?

Yes, we do! Anywhere we use Jekyll::External.require_with_graceful_fail, we are doing that. This PR is for subcommands.

parkr added a commit that referenced this pull request Jan 5, 2016

@parkr parkr merged commit f995d86 into master Jan 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr deleted the shim-docs-import-with-nudge branch Jan 5, 2016

parkr added a commit that referenced this pull request Jan 5, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.