New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change TestDoctorCommand to JekyllUnitTest... #4263

Merged
merged 1 commit into from Dec 15, 2015

Conversation

Projects
None yet
3 participants
@qrush
Contributor

qrush commented Dec 15, 2015

...since Test constant doesn't necessarily exist. Was getting this off a fresh clone + cibuild:

/Users/qrush/.rbenv/versions/2.2.2/bin/ruby -I"lib:lib:test"  "/Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb" "test/**/test_*.rb" 
/Users/qrush/.rbenv/versions/2.2.2/bin/ruby -S bundle exec cucumber  --profile travis
cucumber.yml was not found.  Current directory is /Users/qrush/Dev/jekyll.  Please refer to cucumber's documentation on defining profiles in cucumber.yml.  You must define a 'default' profile to use the cucumber command without any arguments.
Type 'cucumber --help' for usage.
Coverage report generated for Unit Tests to /Users/qrush/Dev/jekyll/coverage. 437 / 1070 LOC (40.84%) covered.
/Users/qrush/Dev/jekyll/test/test_doctor_command.rb:4:in `<top (required)>': uninitialized constant Test (NameError)
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:121:in `require'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/site_ruby/2.2.0/rubygems/core_ext/kernel_require.rb:121:in `require'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb:10:in `block (2 levels) in <main>'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb:9:in `each'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb:9:in `block in <main>'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb:4:in `select'
    from /Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb:4:in `<main>'
rake aborted!
Command failed with status (1): [ruby -I"lib:lib:test"  "/Users/qrush/.rbenv/versions/2.2.2/lib/ruby/2.2.0/rake/rake_test_loader.rb" "test/**/test_*.rb" ]
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 15, 2015

Member

Hi! Thanks for fixing this! 🎉 Looks like we have neglected this test class...

Member

parkr commented Dec 15, 2015

Hi! Thanks for fixing this! 🎉 Looks like we have neglected this test class...

parkr added a commit that referenced this pull request Dec 15, 2015

@parkr parkr merged commit be06296 into jekyll:master Dec 15, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

parkr added a commit that referenced this pull request Dec 15, 2015

@parkr parkr added the fix label Dec 15, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.