New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved namespaced rake tasks to separate .rake files under lib/tasks #4282

Merged
merged 1 commit into from Dec 26, 2015

Conversation

Projects
None yet
4 participants
@leethomas
Contributor

leethomas commented Dec 26, 2015

Hi, I saw #4218 where @envygeeks wanted to split the Rakefile so I did so based on namespaces. I named all of the .rake files by their root namespace (i.e. docs.rake for namespace :docs). Not sure if that's exactly how you guys wanted it, but let me know if not and I'll make the changes.

No tests with this PR since it's just a refactor. All the existing tests passed.

Also merry Christmas, if you celebrate it. 馃巺 馃巵 馃巹

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Dec 26, 2015

Contributor

It this exactly what i was on about, just one minor comment, I would split up tasks without a namespace the same way I split up namespaces since the current form implies analysis is part of documentation, but it's actually it's own task that runs CodeClimate coverage and Rubocop.

Contributor

envygeeks commented Dec 26, 2015

It this exactly what i was on about, just one minor comment, I would split up tasks without a namespace the same way I split up namespaces since the current form implies analysis is part of documentation, but it's actually it's own task that runs CodeClimate coverage and Rubocop.

end
file.close
end

This comment has been minimized.

@parkr

parkr Dec 26, 2015

Member

let's put this in its own .rake file

@parkr

parkr Dec 26, 2015

Member

let's put this in its own .rake file

parkr added a commit that referenced this pull request Dec 26, 2015

@parkr parkr merged commit e3da5a3 into jekyll:master Dec 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 26, 2015

parkr added a commit that referenced this pull request Dec 26, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.