New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drops should use content setters if they exist #4312

Merged
merged 3 commits into from Jan 4, 2016

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jan 4, 2016

@evgenyneu, this fixes your issue as defined here: #4246 (comment)

@parkr parkr added this to the 3.1 milestone Jan 4, 2016

@parkr parkr added the fix label Jan 4, 2016

parkr added a commit that referenced this pull request Jan 4, 2016

@parkr parkr merged commit e097a15 into master Jan 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr deleted the fix-layout-metadata branch Jan 4, 2016

parkr added a commit that referenced this pull request Jan 4, 2016

@evgenyneu

This comment has been minimized.

Show comment
Hide comment
@evgenyneu

evgenyneu Jan 4, 2016

Thank you, I have added this change, but it does not fix my issue.

evgenyneu commented Jan 4, 2016

Thank you, I have added this change, but it does not fix my issue.

---
foo: my custom data
---
{{ content }} foo: {{ layout.foo }}

This comment has been minimized.

@evgenyneu

evgenyneu Jan 4, 2016

In my case I was doing {{ layout.foo }} from parent layout file index.html, not from custom.html.

@evgenyneu

evgenyneu Jan 4, 2016

In my case I was doing {{ layout.foo }} from parent layout file index.html, not from custom.html.

This comment has been minimized.

@parkr

parkr Jan 5, 2016

Member

See a9b80b2 for this. It works on master according to my scenario.

@parkr

parkr Jan 5, 2016

Member

See a9b80b2 for this. It works on master according to my scenario.

parkr added a commit that referenced this pull request Jan 5, 2016

@evgenyneu

This comment has been minimized.

Show comment
Hide comment
@evgenyneu

evgenyneu Jan 5, 2016

Yes, you are right, @parkr, thank you. I needed to install jekyll from master to make it work.

evgenyneu commented Jan 5, 2016

Yes, you are right, @parkr, thank you. I needed to install jekyll from master to make it work.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.