Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for smartify Liquid filter #4333

Merged
merged 1 commit into from Jan 10, 2016
Merged

Add documentation for smartify Liquid filter #4333

merged 1 commit into from Jan 10, 2016

Conversation

@pathawks
Copy link
Member

@pathawks pathawks commented Jan 10, 2016

Add documentation for #4323

Sorry, this probably should have been part of that PR.

@parkr
Copy link
Member

@parkr parkr commented Jan 10, 2016

Ah, yes! Thank you. :)

@parkr
Copy link
Member

@parkr parkr commented Jan 10, 2016

@jekyllbot: merge +site

jekyllbot added a commit that referenced this issue Jan 10, 2016
@jekyllbot jekyllbot merged commit 53e4c16 into jekyll:master Jan 10, 2016
1 check failed
@pathawks pathawks deleted the smartypants branch Jan 10, 2016
@ghost
Copy link

@ghost ghost commented Jan 31, 2017

@pathawks et. al, would it be useful to also indicate in the documentation smartify will handle converting -- into an ndash? Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

@pathawks
Copy link
Member Author

@pathawks pathawks commented Jan 31, 2017

Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

Can you provide a bit more detail?

@ghost
Copy link

@ghost ghost commented Jan 31, 2017

Can you provide a bit more detail?

{{ content | smartify }} results in -- output to page where content contains --. I tried this at the default layout with and without using the compress layout. Same thing goes for angle quotes.

@pathawks
Copy link
Member Author

@pathawks pathawks commented Jan 31, 2017

Because smartify doesn’t affect anything inside text wrapped with HTML tags?
I'm guessing.

I guess smartify is really meant to be used on simple strings – like a title or something. For content, Markdown processors are already able to make these substitutions.

@ghost
Copy link

@ghost ghost commented Jan 31, 2017

Ah, that makes good sense. Thanks @pathawks

@pathawks
Copy link
Member Author

@pathawks pathawks commented Jan 31, 2017

@jhabdas You could open a PR if you think this is worth mentioning in the docs 👍

@ghost
Copy link

@ghost ghost commented Jan 31, 2017

Sounds good to me. Need to grok our discussion in gettalong/kramdown#299 a little more before I do. Thanks for staying on top of these issues and all of your helpful feedback, @pathawks.

@jekyll jekyll locked and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants