Add documentation for smartify Liquid filter #4333

Merged
merged 1 commit into from Jan 10, 2016

Conversation

Projects
None yet
4 participants
@pathawks
Member

pathawks commented Jan 10, 2016

Add documentation for jekyll/jekyll#4323

Sorry, this probably should have been part of that PR.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 10, 2016

Member

Ah, yes! Thank you. :)

Member

parkr commented Jan 10, 2016

Ah, yes! Thank you. :)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 10, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Jan 10, 2016

@jekyllbot: merge +site

jekyllbot added a commit that referenced this pull request Jan 10, 2016

@jekyllbot jekyllbot merged commit 53e4c16 into jekyll:master Jan 10, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

jekyllbot added a commit that referenced this pull request Jan 10, 2016

@pathawks pathawks deleted the pathawks:smartypants branch Jan 10, 2016

@jhabdas jhabdas referenced this pull request in Phlow/feeling-responsive Jan 31, 2017

Closed

Heading anchors not output in HTML #120

@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Jan 31, 2017

Contributor

@pathawks et. al, would it be useful to also indicate in the documentation smartify will handle converting -- into an ndash? Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

Contributor

jhabdas commented Jan 31, 2017

@pathawks et. al, would it be useful to also indicate in the documentation smartify will handle converting -- into an ndash? Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 31, 2017

Member

Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

Can you provide a bit more detail?

Member

pathawks commented Jan 31, 2017

Also, I noticed the filter works with page.title but not content. If that's expected, is it also worth mentioning?

Can you provide a bit more detail?

@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Jan 31, 2017

Contributor

Can you provide a bit more detail?

{{ content | smartify }} results in -- output to page where content contains --. I tried this at the default layout with and without using the compress layout. Same thing goes for angle quotes.

Contributor

jhabdas commented Jan 31, 2017

Can you provide a bit more detail?

{{ content | smartify }} results in -- output to page where content contains --. I tried this at the default layout with and without using the compress layout. Same thing goes for angle quotes.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 31, 2017

Member

Because smartify doesn’t affect anything inside text wrapped with HTML tags?
I'm guessing.

I guess smartify is really meant to be used on simple strings – like a title or something. For content, Markdown processors are already able to make these substitutions.

Member

pathawks commented Jan 31, 2017

Because smartify doesn’t affect anything inside text wrapped with HTML tags?
I'm guessing.

I guess smartify is really meant to be used on simple strings – like a title or something. For content, Markdown processors are already able to make these substitutions.

@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Jan 31, 2017

Contributor

Ah, that makes good sense. Thanks @pathawks

Contributor

jhabdas commented Jan 31, 2017

Ah, that makes good sense. Thanks @pathawks

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 31, 2017

Member

@jhabdas You could open a PR if you think this is worth mentioning in the docs 👍

Member

pathawks commented Jan 31, 2017

@jhabdas You could open a PR if you think this is worth mentioning in the docs 👍

@jhabdas

This comment has been minimized.

Show comment
Hide comment
@jhabdas

jhabdas Jan 31, 2017

Contributor

Sounds good to me. Need to grok our discussion in gettalong/kramdown#299 a little more before I do. Thanks for staying on top of these issues and all of your helpful feedback, @pathawks.

Contributor

jhabdas commented Jan 31, 2017

Sounds good to me. Need to grok our discussion in gettalong/kramdown#299 a little more before I do. Thanks for staying on top of these issues and all of your helpful feedback, @pathawks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment