Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script/travis so all people can play with Travis-CI images. #4338

Merged
merged 1 commit into from Jan 10, 2016

Conversation

@envygeeks
Copy link
Contributor

@envygeeks envygeeks commented Jan 10, 2016

No description provided.

@@ -0,0 +1,33 @@
#!/bin/sh

This comment has been minimized.

@parkr

parkr Jan 10, 2016
Member

Would you mind adding usage info up here?

This comment has been minimized.

@envygeeks

envygeeks Jan 10, 2016
Author Contributor

I'm gonna be honest, this is for programmers so if they can't get usage info from the simple 2 if's they shouldn't be using it. I'm on the fence about whether I wish to comply with this because the script is so simple.

This comment has been minimized.

@envygeeks

envygeeks Jan 10, 2016
Author Contributor

Let me rephrase that, did you understand how to use it @parkr?

This comment has been minimized.

@parkr

parkr Jan 10, 2016
Member

I think it's simple enough, but usage examples save time. It took me a second to understand what $1 and $2 were supposed to do because I had to hunt. I sometimes have to get usage help for things because I use so many tools every day that I can mix them up sometimes.

This comment has been minimized.

@envygeeks

envygeeks Jan 10, 2016
Author Contributor

That's fair then, after I finish up the ObjectSpace removal I'll add a usage info.

@envygeeks envygeeks force-pushed the pr/add-script-travis branch from 8617019 to 9fee9d3 Jan 10, 2016
@envygeeks
Copy link
Contributor Author

@envygeeks envygeeks commented Jan 10, 2016

Done.

@parkr
Copy link
Member

@parkr parkr commented Jan 10, 2016

You rock! 🎉

@parkr
Copy link
Member

@parkr parkr commented Jan 10, 2016

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 10, 2016
@jekyllbot jekyllbot merged commit 1de7449 into master Jan 10, 2016
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jekyllbot jekyllbot deleted the pr/add-script-travis branch Jan 10, 2016
jekyllbot added a commit that referenced this pull request Jan 10, 2016
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants