Move Cucumber to using RSpec-Expections and furthering JRuby support. #4343

Merged
merged 1 commit into from Jan 11, 2016

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Jan 10, 2016

  • Removes posix-spawn in favor of Open3#popen3
  • Encapsulates all the paths into a single easy class.
  • Moves to %r{} to avoid ambiguious warnings per-Cucumber suggestion.
  • Starts passing around Pathname to make some actions faster.
  • Clean's up some methods to make them easier to read.
  • AUTOMATIC: Add "#" between each method.
Move Cucumber to using RSpec-Expections and furthering JRuby support.
* Removes posix-spawn in favor of Open3#popen3
* Encapsulates all the paths into a single easy class.
* Moves to %r{} to avoid ambiguious warnings per-Cucumber suggestion.
* Starts passing around Pathname to make some actions faster.
* Clean's up some methods to make them easier to read.
* AUTOMATIC: Add "#" between each method.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 11, 2016

Member

@envygeeks Is this ready for review now that CI is green?

Member

parkr commented Jan 11, 2016

@envygeeks Is this ready for review now that CI is green?

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 11, 2016

Contributor

@parkr yessum.

Contributor

envygeeks commented Jan 11, 2016

@parkr yessum.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 11, 2016

Member

LGTM!

@jekyllbot: merge +dev

Member

parkr commented Jan 11, 2016

LGTM!

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 11, 2016

@jekyllbot jekyllbot merged commit 3e30c72 into master Jan 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pr/cucumber-rspec-expec-jruby-support branch Jan 11, 2016

jekyllbot added a commit that referenced this pull request Jan 11, 2016

@pathawks pathawks referenced this pull request May 24, 2016

Merged

Rubocop: features #4934

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.