Rearrange Cucumber and add some flair. #4347

Merged
merged 1 commit into from Jan 11, 2016

Conversation

Projects
None yet
4 participants
@envygeeks
Contributor

envygeeks commented Jan 11, 2016

  • Move step_definitions/jekyll.rb to just step_definitions.rb
  • Rename the formatter to Jekyll::Cucumber::Formatter, it's Jekyll's.
  • Add some flair; switch to checks!
  • Rename env.rb to helpers.rb

  • The renaming of env.rb to helpers.rb facilitates what it actually does and hints at people contributing as to what it does and where to place stuff if they are inside of Cucumber.
  • The moving of step_definitions is because it removes a single file folder.
  • The flair is just because.
Rearrange Cucumber and add some flair.
* Move step_definitions/jekyll.rb to just step_definitions.rb
* Rename the formatter to Jekyll::Cucumber::Formatter, it's Jekyll's.
* Add some flair; switch to checks!
* Rename env.rb to helpers.rb
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 11, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Jan 11, 2016

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 11, 2016

@jekyllbot jekyllbot merged commit 4dccb00 into master Jan 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the rearrange-cucumber-add-flair branch Jan 11, 2016

jekyllbot added a commit that referenced this pull request Jan 11, 2016

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jan 11, 2016

Member

I'm surprised cucumber doesn't break without a step_definitions folder.

Member

mattr- commented Jan 11, 2016

I'm surprised cucumber doesn't break without a step_definitions folder.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 11, 2016

Member

@mattr- shrug

Member

parkr commented Jan 11, 2016

@mattr- shrug

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 11, 2016

Contributor

@mattr- I was surprised too, I was adding Cucumber to an app I was building and said "man this single folder file is ugly" so I tried it and it worked so I was like YAY for organization.

Contributor

envygeeks commented Jan 11, 2016

@mattr- I was surprised too, I was adding Cucumber to an app I was building and said "man this single folder file is ugly" so I tried it and it worked so I was like YAY for organization.

@pathawks pathawks referenced this pull request May 24, 2016

Merged

Rubocop: features #4934

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.