New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the Gemfile (and keep all the necessary dependencies) #4350

Merged
merged 2 commits into from Jan 12, 2016

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Jan 12, 2016

The problem last time was that we removed Pry and Pry brings in CodeRay, we were
testing legacy stuff and didn't have CodeRay in our dependencies, which resulted
in those tests failing.

This also quietly announces the intention to move to RSpec by moving the old
test dependencies to ":test_legacy" and is slightly less agressive in it's
organization than before.

envygeeks added some commits Jan 12, 2016

Try to cleanup the Gemfile... again.
The problem last time was that we removed Pry and Pry brings in CodeRay, we were
testing legacy stuff and didn't have CodeRay in our dependencies, which resulted
in those tests failing.

This also quietly announces the intention to move to RSpec by moving the old
test dependencies to ":test_legacy" and is slightly less agressive in it's
organization than before.

@parkr parkr changed the title from Try to cleanup the Gemfile... again. to Clean up the Gemfile (and keep all the necessary dependencies) Jan 12, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 12, 2016

Member

Great! Thank you for this. I'll add pr/ to the list of accepted prefixes for autopull, too!

@jekyllbot: merge +dev

Member

parkr commented Jan 12, 2016

Great! Thank you for this. I'll add pr/ to the list of accepted prefixes for autopull, too!

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 12, 2016

@jekyllbot jekyllbot merged commit 9c4695c into master Jan 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pr/cleanup-gemfile branch Jan 12, 2016

jekyllbot added a commit that referenced this pull request Jan 12, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.