-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Upgrade to Liquid v4 #4362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Liquid v4 #4362
Conversation
Line 46 in 281f751
This could be worked around by using |
Would this affect normal everyday plugins @dylanahsmith ? |
👍
This looks like it's only in our tests where this is going to be an issue. Most plugins don't use this |
@dylanahsmith Our tests depend on having access to the instance created. I gave it a shot with It looks like v4 works (CI works fine for me locally). Would you consider releasing a new version soon and we can upgrade? |
@dylanahsmith @fw42 @pushrax Hi! Would it be possible to reconsider a 4.0 release? Especially keen to get the whitespace change out to our users. Thanks! |
I'm ok with releasing a new version of Liquid. As far as I know, there isn't any pending non-backwards compatible changes that we want to get in before a new release. @pushrax @dylanahsmith, thoughts? |
version ⬆️ 👍 |
Also 🆗 from me |
Yea I just released 4.0rc versions of both Liquid and Liquid-C. @parkr, can you see if everything works on your end? If so, I can release a real non-rc release. |
Interesting –– all of our |
Looks like things are working here. I'd be interested in getting this into a v3.4, though I have concerns about what incompatibilities for plugin authors. |
@fw42 If this CI passes, then feel free to release v4.0 of Liquid. ❤️ |
When will this PR be merged? Patiently waiting for liquid 4.0 features ;) . Also I was trying to find where you list when the next release and ship date is planned for. |
I think we'll try to ship a 3.4 this week, with a 3.5 a bit after that. |
Fixes #5772. |
Any update on this? Waiting not quite as patiently as @JamesDrummond ;). |
@jekyllbot: merge +minor |
RC1 for now.
@fw42 @dylanahsmith, know what's going on here?
.parse
isn't working like before.