Page should respect output extension of its permalink #4373

Merged
merged 19 commits into from Jan 18, 2016

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Jan 18, 2016

I believe this completes mpc-hc/mpc-hc.org#58 for @XhmikosR.

This PR includes some other enhancements which will make it easier
to move Page over to Renderer and away from Convertible by 3.2.

Fixes #4182, #4193, #4082.

@parkr parkr added the fix label Jan 18, 2016

@parkr parkr added this to the 3.1 milestone Jan 18, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 18, 2016

Contributor

What is this?

Contributor

envygeeks commented on e9c5c45 Jan 18, 2016

What is this?

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2016

Member

An error. Fixed in be0e951

Member

parkr replied Jan 18, 2016

An error. Fixed in be0e951

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 18, 2016

Contributor

This impedes performance as true is a constant.

Contributor

envygeeks commented on lib/jekyll/page.rb in e5d8bde Jan 18, 2016

This impedes performance as true is a constant.

This comment has been minimized.

Show comment
Hide comment
Member

parkr replied Jan 18, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Jan 18, 2016

@jekyllbot: merge +bug

jekyllbot added a commit that referenced this pull request Jan 18, 2016

@jekyllbot jekyllbot merged commit c5830ce into master Jan 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the page-as-renderable branch Jan 18, 2016

jekyllbot added a commit that referenced this pull request Jan 18, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 18, 2016

Member

@envygeeks Whoops! Didn't see you commenting there. I'll fix up the things you pointed out. Thanks!

Member

parkr commented Jan 18, 2016

@envygeeks Whoops! Didn't see you commenting there. I'll fix up the things you pointed out. Thanks!

@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Jan 19, 2016

Contributor

seems totally reasonable. I'm not sure how common the "dots in filename that don't identify a file extension" case really was.

I'm a little surprised permalink: /+/plus+in+url didn't work though. I just tried a similar permalink in the frontmatter of a page and it worked as I would have expected... generated file on disk is "plus+in+url.html" and requests for extensionless URL work fine.

Contributor

willnorris commented on 2de5bac Jan 19, 2016

seems totally reasonable. I'm not sure how common the "dots in filename that don't identify a file extension" case really was.

I'm a little surprised permalink: /+/plus+in+url didn't work though. I just tried a similar permalink in the frontmatter of a page and it worked as I would have expected... generated file on disk is "plus+in+url.html" and requests for extensionless URL work fine.

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 19, 2016

Member

@willnorris: I believe you're right about plus+in+url. Would you kindly submit a quick PR removing the .html I added? I believe this commit was earlier in the stack.

Member

parkr replied Jan 19, 2016

@willnorris: I believe you're right about plus+in+url. Would you kindly submit a quick PR removing the .html I added? I believe this commit was earlier in the stack.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.