Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page should respect output extension of its permalink #4373

Merged
merged 19 commits into from Jan 18, 2016
Merged

Conversation

@parkr
Copy link
Member

@parkr parkr commented Jan 18, 2016

I believe this completes mpc-hc/mpc-hc.org#58 for @XhmikosR.

This PR includes some other enhancements which will make it easier
to move Page over to Renderer and away from Convertible by 3.2.

Fixes #4182, #4193, #4082.

@parkr parkr added the fix label Jan 18, 2016
@parkr parkr added this to the 3.1 milestone Jan 18, 2016
envygeeks
Copy link
Contributor

envygeeks commented on e9c5c45 Jan 18, 2016

What is this?

parkr
Copy link
Member

parkr commented on e9c5c45 Jan 18, 2016

An error. Fixed in be0e951

@parkr
Copy link
Member Author

@parkr parkr commented Jan 18, 2016

@jekyllbot: merge +bug

jekyllbot added a commit that referenced this issue Jan 18, 2016
@jekyllbot jekyllbot merged commit c5830ce into master Jan 18, 2016
1 check passed
@jekyllbot jekyllbot deleted the page-as-renderable branch Jan 18, 2016
@parkr
Copy link
Member Author

@parkr parkr commented Jan 18, 2016

@envygeeks Whoops! Didn't see you commenting there. I'll fix up the things you pointed out. Thanks!

willnorris
Copy link
Contributor

willnorris commented on 2de5bac Jan 19, 2016

seems totally reasonable. I'm not sure how common the "dots in filename that don't identify a file extension" case really was.

I'm a little surprised permalink: /+/plus+in+url didn't work though. I just tried a similar permalink in the frontmatter of a page and it worked as I would have expected... generated file on disk is "plus+in+url.html" and requests for extensionless URL work fine.

parkr
Copy link
Member

parkr commented on 2de5bac Jan 19, 2016

@willnorris: I believe you're right about plus+in+url. Would you kindly submit a quick PR removing the .html I added? I believe this commit was earlier in the stack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants