Update & prune the short list of example sites #4374

Merged
merged 2 commits into from Feb 8, 2016

Conversation

Projects
None yet
4 participants
@fusion809
Contributor

fusion809 commented Jan 19, 2016

I am making this pull request as I think that this page could do with an indicator of when each of these sites were last updated as this gives one an idea as to whether or not these sites are still valid examples to follow (as it is possible that their code has become outdated and so has their layout, due to new releases of Jekyll).

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 19, 2016

Contributor

This is a hostile commit IMO. It's a burden to maintain such a thing, would rarely be updated and if the user suddenly updates their source, misleads anybody browsing our site. It's really not that hard to click the link and see on the Source page exactly when it was updated last.

Contributor

envygeeks commented Jan 19, 2016

This is a hostile commit IMO. It's a burden to maintain such a thing, would rarely be updated and if the user suddenly updates their source, misleads anybody browsing our site. It's really not that hard to click the link and see on the Source page exactly when it was updated last.

@fusion809

This comment has been minimized.

Show comment
Hide comment
@fusion809

fusion809 Jan 19, 2016

Contributor

True, but I was hoping this might help one find up-to-date sites faster. I will accept this commit being trumped but two of those sites listed haven't been updated in over two years, do yas (the maintainers of this repo) still think they're valid examples for the currently-supported releases of Jekyll? Oh and I just realized that GitHub training source link should be to https://github.com/github/training-kit, as the repo linked has moved.

Contributor

fusion809 commented Jan 19, 2016

True, but I was hoping this might help one find up-to-date sites faster. I will accept this commit being trumped but two of those sites listed haven't been updated in over two years, do yas (the maintainers of this repo) still think they're valid examples for the currently-supported releases of Jekyll? Oh and I just realized that GitHub training source link should be to https://github.com/github/training-kit, as the repo linked has moved.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 19, 2016

Contributor

/cc @jekyll/core

Contributor

envygeeks commented Jan 19, 2016

/cc @jekyll/core

@fusion809

This comment has been minimized.

Show comment
Hide comment
@fusion809

fusion809 Jan 19, 2016

Contributor

Look at my second commit, is this more amenable?

Contributor

fusion809 commented Jan 19, 2016

Look at my second commit, is this more amenable?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 19, 2016

Member

I'll take a look at this in a bit. This list is very old and there might be some political elements to adding or removing. Thanks!

Member

parkr commented Jan 19, 2016

I'll take a look at this in a bit. This list is very old and there might be some political elements to adding or removing. Thanks!

@fusion809

This comment has been minimized.

Show comment
Hide comment
@fusion809

fusion809 Jan 22, 2016

Contributor

@pakr If you want to add another site to this list feel free to add mine "The Hornery" at https://fusion809.github.io, source: https://github.com/fusion809/fusion809.github.io. I think it would be helpful for instructional purposes as look at my README: https://github.com/fusion809/fusion809.github.io/blob/master/README.md. It gives Jekyll-related instructions for Linux users in particular.

Contributor

fusion809 commented Jan 22, 2016

@pakr If you want to add another site to this list feel free to add mine "The Hornery" at https://fusion809.github.io, source: https://github.com/fusion809/fusion809.github.io. I think it would be helpful for instructional purposes as look at my README: https://github.com/fusion809/fusion809.github.io/blob/master/README.md. It gives Jekyll-related instructions for Linux users in particular.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 22, 2016

Contributor

Jekyll doesn't run on Debian Ruby it only runs on Ubuntu Ruby if you are above 15.04 (which is EOL.)

Contributor

envygeeks commented Jan 22, 2016

Jekyll doesn't run on Debian Ruby it only runs on Ubuntu Ruby if you are above 15.04 (which is EOL.)

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 22, 2016

Contributor

I take that back, they finally updated it, so nevermind, it runs on Debian Ruby, carry on.

Contributor

envygeeks commented Jan 22, 2016

I take that back, they finally updated it, so nevermind, it runs on Debian Ruby, carry on.

@parkr parkr added the documentation label Feb 8, 2016

@parkr parkr changed the title from Adding commit/date indicators to Update & prune the short list of example sites Feb 8, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 8, 2016

Member

@jekyllbot: merge +site

Member

parkr commented Feb 8, 2016

@jekyllbot: merge +site

jekyllbot added a commit that referenced this pull request Feb 8, 2016

@jekyllbot jekyllbot merged commit 3b5f91a into jekyll:master Feb 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Feb 8, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.