Document: throw a useful error when an invalid date is given #4378

Merged
merged 1 commit into from Jan 20, 2016

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jan 20, 2016

@parkr parkr added this to the 3.0.2 milestone Jan 20, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 20, 2016

Member

Also, this is really gross. Can't wait to have custom errors. /cc #4310.

Member

parkr commented Jan 20, 2016

Also, this is really gross. Can't wait to have custom errors. /cc #4310.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 20, 2016

Contributor

Why not just source: :frontmatter? The way that is pretty expensive, even with literals compared to a symbol.

Why not just source: :frontmatter? The way that is pretty expensive, even with literals compared to a symbol.

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Jan 20, 2016

Contributor

Oh, I see why, I don't know what to think because if that has to happen things might be getting a bit complex.

Contributor

envygeeks replied Jan 20, 2016

Oh, I see why, I don't know what to think because if that has to happen things might be getting a bit complex.

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 20, 2016

Member

It's about the error messages. If we run into an issue parsing something, we should be able to tell the user where it came from.

Member

parkr replied Jan 20, 2016

It's about the error messages. If we run into an issue parsing something, we should be able to tell the user where it came from.

@parkr parkr added the fix label Jan 20, 2016

parkr added a commit that referenced this pull request Jan 20, 2016

Merge pull request #4378 from jekyll/invalid-date-error
Document: throw a useful error when an invalid date is given

@parkr parkr merged commit f4523cb into 3.0-stable Jan 20, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the invalid-date-error branch Jan 20, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.