New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress stdout in liquid profiling test #4409

Merged
merged 1 commit into from Jan 28, 2016

Conversation

Projects
None yet
3 participants
@alfredxing
Member

alfredxing commented Jan 27, 2016

The test was spewing out some whitespace ¯_(ツ)_/¯
This just suppresses output to STDOUT for this test only.

Previously:

screen shot 2016-01-27 at 1 44 09 pm

Suppress stdout in liquid profiling test
The test was spewing out some whitespace
@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jan 27, 2016

Member

@envygeeks: This is a smell, prefer $stdout over $>

Fixed, thanks for the suggestion 👍

Member

alfredxing commented Jan 27, 2016

@envygeeks: This is a smell, prefer $stdout over $>

Fixed, thanks for the suggestion 👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 28, 2016

Member

@jekyllbot: merge +dev

Member

parkr commented Jan 28, 2016

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 28, 2016

@jekyllbot jekyllbot merged commit 0b32252 into jekyll:master Jan 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 28, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 28, 2016

Member

Thanks so much, @alfredxing! I was wondering where that newline came from but didn't have time to dig into it. 😄

Member

parkr commented Jan 28, 2016

Thanks so much, @alfredxing! I was wondering where that newline came from but didn't have time to dig into it. 😄

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.