Fix #4427: Make our @config hash symbol accessible. #4428

Merged
merged 2 commits into from Feb 2, 2016

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Jan 30, 2016

No description provided.

end
def convert(content)
Kramdown::Document.new(content, @config).to_html
end
+ private
+ def make_accessible(hash = @config)
+ proc_ = proc { |hash_, key| hash_[key.to_s] if key.is_a?(Symbol) }

This comment has been minimized.

@parkr

parkr Feb 1, 2016

Member

When do we access with symbols? What happened to the coderay/kramdown GFM stuff that requires this?

@parkr

parkr Feb 1, 2016

Member

When do we access with symbols? What happened to the coderay/kramdown GFM stuff that requires this?

This comment has been minimized.

@envygeeks

envygeeks Feb 2, 2016

Contributor

We don't, it's because Kramdown wants symbols and we want strings. So we give the best of both worlds so we don't disrupt our behavior and they can access it how they wish to without affecting us and us blindly accepting symbols.

@envygeeks

envygeeks Feb 2, 2016

Contributor

We don't, it's because Kramdown wants symbols and we want strings. So we give the best of both worlds so we don't disrupt our behavior and they can access it how they wish to without affecting us and us blindly accepting symbols.

@parkr parkr added the fix label Feb 1, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 2, 2016

Member

@jekyllbot: merge +bug

Member

parkr commented Feb 2, 2016

@jekyllbot: merge +bug

jekyllbot added a commit that referenced this pull request Feb 2, 2016

@jekyllbot jekyllbot merged commit 27535e2 into master Feb 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the bug/make-config-symbol-accessible branch Feb 2, 2016

jekyllbot added a commit that referenced this pull request Feb 2, 2016

@parkr parkr referenced this pull request Feb 2, 2016

Closed

rogue ~> rouge #4445

@envygeeks envygeeks added this to the 3.1.2 milestone Feb 2, 2016

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.