Site Template: write a Gemfile which is educational to the new site #4542

Merged
merged 4 commits into from Mar 24, 2016

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Feb 19, 2016

Fixes #4539. Kind of.

  • Create Gemfile template
  • Test it

@parkr parkr added this to the 3.2 milestone Feb 19, 2016

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Feb 19, 2016

Contributor

Pathutil.new("Gemfile").expand_path(new_blog_path).write(data), works for Pathname too.

Pathutil.new("Gemfile").expand_path(new_blog_path).write(data), works for Pathname too.

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 19, 2016

Member

Did you add pathutil yet?

Member

parkr replied Feb 19, 2016

Did you add pathutil yet?

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Feb 19, 2016

Contributor

Not yet, but you can add it to the surface as a dependency (which won't affect the pull coming) and start doing new work with it.

Contributor

envygeeks replied Feb 19, 2016

Not yet, but you can add it to the surface as a dependency (which won't affect the pull coming) and start doing new work with it.

@parkr parkr added the enhancement label Feb 19, 2016

lib/jekyll/commands/new.rb
+source 'https://rubygems.org'
+
+# Hello! This is where you manage which Jekyll version is used to run.
+# When you wwant to use a different version, change it below, save the

This comment has been minimized.

@benbalter

benbalter Feb 19, 2016

Contributor

wwant -> want

@benbalter

benbalter Feb 19, 2016

Contributor

wwant -> want

@benbalter

This comment has been minimized.

Show comment
Hide comment
@benbalter

benbalter Feb 19, 2016

Contributor

I'm a big fan of this. Was kinda surprised the default site didn't come with a Gemfile. Think it'd go a long way to help ease non-Ruby users into the Jekyll world, and if a user doesn't use Bundler, no harm done.

Contributor

benbalter commented Feb 19, 2016

I'm a big fan of this. Was kinda surprised the default site didn't come with a Gemfile. Think it'd go a long way to help ease non-Ruby users into the Jekyll world, and if a user doesn't use Bundler, no harm done.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 24, 2016

Member

@jekyll/stability, look good to you?

Member

parkr commented Mar 24, 2016

@jekyll/stability, look good to you?

@parkr parkr changed the title from `jekyll new` should create a Gemfile which is educational to Site Template: write a Gemfile which is educational to the new site Mar 24, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 24, 2016

Member

@jekyllbot: merge +minor

Member

parkr commented Mar 24, 2016

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 87d0f03 into master Mar 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the jekyll-new-with-gemfile branch Mar 24, 2016

jekyllbot added a commit that referenced this pull request Mar 24, 2016

parkr added a commit that referenced this pull request Mar 26, 2016

Merge remote-tracking branch 'origin/master' into themes
* origin/master: (65 commits)
  Update history to reflect merge of #4703 [ci skip]
  Update history to reflect merge of #4712 [ci skip]
  Highlight the test code
  Update history to reflect merge of #4640 [ci skip]
  readded "env=prod"-condition
  Update history to reflect merge of #3849 [ci skip]
  Update history to reflect merge of #4624 [ci skip]
  Update history to reflect merge of #4704 [ci skip]
  Update history to reflect merge of #4706 [ci skip]
  Checks for link file extension in tests
  Updating assets documentation
  Fix test teardown for cleaner.
  Update history to reflect merge of #4542 [ci skip]
  Add explanation of site variables in the example _config.yml
  Use double quotes in the gemfile
  Add test for creation of Gemfile by 'jekyll new'
  Add comment about github-pages
  Update history to reflect merge of #4533 [ci skip]
  Ensure Rouge closes its div/figure properly after highlighting ends.
  Add Site#config= which can be used to set the config
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment