New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add size property to group_by result #4557

Merged
merged 2 commits into from Mar 1, 2016

Conversation

Projects
None yet
4 participants
@timwis
Contributor

timwis commented Feb 21, 2016

This allows you to do {% assign subset = site.pages | group_by:"author" | sort:"size" %} so that you can list the groups in order of the number of items they have.

If there's a way to do this already please let me know; I don't see how it would be possible without this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 23, 2016

Member

This LGTM. @jekyll/core, what do you think? @benbalter?

Member

parkr commented Feb 23, 2016

This LGTM. @jekyll/core, what do you think? @benbalter?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 23, 2016

Member

@timwis This needs a test, please.

Member

parkr commented Feb 23, 2016

@timwis This needs a test, please.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Feb 23, 2016

Contributor

LGTM.

Contributor

envygeeks commented Feb 23, 2016

LGTM.

@timwis

This comment has been minimized.

Show comment
Hide comment
@timwis

timwis Feb 25, 2016

Contributor

Sure thing @parkr, just added a test.

Contributor

timwis commented Feb 25, 2016

Sure thing @parkr, just added a test.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 1, 2016

Member

Thanks a lot, @timwis! Looking good to me.

@jekyllbot: merge +minor

Member

parkr commented Mar 1, 2016

Thanks a lot, @timwis! Looking good to me.

@jekyllbot: merge +minor

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@jekyllbot jekyllbot merged commit cddea27 into jekyll:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@parkr parkr added the enhancement label Mar 1, 2016

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@parkr parkr added this to the 3.2 milestone Mar 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment