Filters#time: clone an input Time so as to be non-destructive #4590

Merged
merged 1 commit into from Mar 1, 2016

Conversation

Projects
None yet
4 participants
@tonyg
Contributor

tonyg commented Feb 26, 2016

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 26, 2016

Member

Fixes #4582.

@willnorris, does this happen to also fix your issue in the Jekyll 3 upgrade around #localtime changing when your links are generated?

Member

parkr commented Feb 26, 2016

Fixes #4582.

@willnorris, does this happen to also fix your issue in the Jekyll 3 upgrade around #localtime changing when your links are generated?

@parkr parkr added the fix label Feb 26, 2016

@parkr parkr changed the title from Fix for issue #4582, plus simple test to Filters#time: clone an input Time so as to be non-destructive Mar 1, 2016

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 1, 2016

Member

@tonyg Thanks so much! 😄

@envygeeks tried .dup and it broke the test. We have to full-out clone to make this work.

@jekyllbot: merge +bug

Member

parkr commented Mar 1, 2016

@tonyg Thanks so much! 😄

@envygeeks tried .dup and it broke the test. We have to full-out clone to make this work.

@jekyllbot: merge +bug

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@jekyllbot jekyllbot merged commit c16a2f4 into jekyll:master Mar 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Mar 1, 2016

@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Mar 1, 2016

Contributor

@parkr no, initial testing doesn't seem to indicate that this makes a difference with the problem I was having. I'll keep digging a bit though.

Contributor

willnorris commented Mar 1, 2016

@parkr no, initial testing doesn't seem to indicate that this makes a difference with the problem I was having. I'll keep digging a bit though.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 1, 2016

Member

@willnorris Ah, bummer. Thanks for letting me know. Let me know if you find anything!

Member

parkr commented Mar 1, 2016

@willnorris Ah, bummer. Thanks for letting me know. Let me know if you find anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment